Skip host heuristics in unit tests

The heuristics may fail if the builder container is not running as
privileged, but they are also not needed for unit testing, so we can
just skip them. Normal collector operation will always execute the
heuristics.

Author: Molter73

collector/lib/CollectorConfig.cpp

@@ -91,7 +91,7 @@ PathEnvVar config_file("ROX_COLLECTOR_CONFIG_PATH", "/etc/stackrox/runtime_confi
 
 const UnorderedSet<L4ProtoPortPair> CollectorConfig::kIgnoredL4ProtoPortPairs = {{L4Proto::UDP, 9}};
 
-CollectorConfig::CollectorConfig(CollectorArgs* args)
+CollectorConfig::CollectorConfig(CollectorArgs* args, bool skipHeuristics)
     : host_proc_(GetHostPath("/proc")),
       disable_network_flows_(disable_network_flows),
       scrape_listen_endpoints_(ports_feature_flag),
@@ -135,7 +135,9 @@ CollectorConfig::CollectorConfig(CollectorArgs* args)
   HandleConnectionStatsQuantiles();
   HandleConfig(config_file.value());
 
-  host_config_ = ProcessHostHeuristics(*this);
+  if (!skipHeuristics) {
+    host_config_ = ProcessHostHeuristics(*this);
+  }
 }
 
 void CollectorConfig::HandleArgs(const CollectorArgs* args) {

collector/lib/CollectorConfig.h

@@ -60,7 +60,7 @@ class CollectorConfig {
   static const UnorderedSet<L4ProtoPortPair> kIgnoredL4ProtoPortPairs;
 
   CollectorConfig() = delete;
-  CollectorConfig(CollectorArgs* collectorArgs);
+  CollectorConfig(CollectorArgs* collectorArgs, bool skipHeuristics = false);
 
   bool TurnOffScrape() const { return turn_off_scrape_; }
   bool ScrapeListenEndpoints() const { return scrape_listen_endpoints_; }

collector/test/CollectorConfigTest.cpp

@@ -13,7 +13,7 @@ namespace collector {
 
 class MockCollectorConfig : public CollectorConfig {
  public:
-  MockCollectorConfig() : CollectorConfig(nullptr) {}
+  MockCollectorConfig() : CollectorConfig(nullptr, true) {}
 
   void MockSetSinspBufferSize(unsigned int value) {
     SetSinspBufferSize(value);

collector/test/HostHeuristicsTest.cpp

@@ -51,7 +51,7 @@ class MockHostInfoHeuristics : public HostInfo {
 class MockCollectorConfig : public CollectorConfig {
  public:
   MockCollectorConfig()
-      : CollectorConfig(nullptr) {};
+      : CollectorConfig(nullptr, true) {};
 
   void SetCollectionMethod(CollectionMethod cm) {
     if (host_config_.HasCollectionMethod()) {

collector/test/NetworkStatusNotifierTest.cpp

@@ -70,7 +70,7 @@ class Semaphore {
 
 class MockCollectorConfig : public collector::CollectorConfig {
  public:
-  MockCollectorConfig() : collector::CollectorConfig(nullptr) {}
+  MockCollectorConfig() : collector::CollectorConfig(nullptr, true) {}
 
   void DisableAfterglow() {
     enable_afterglow_ = false;
@@ -185,7 +185,7 @@ class NetworkConnectionInfoMessageParser {
 /* Simple validation that the service starts and sends at least one event */
 TEST(NetworkStatusNotifier, SimpleStartStop) {
   bool running = true;
-  CollectorConfig config_(nullptr);
+  CollectorConfig config_(nullptr, true);
   std::shared_ptr<MockConnScraper> conn_scraper = std::make_shared<MockConnScraper>();
   auto conn_tracker = std::make_shared<ConnectionTracker>();
   auto comm = std::make_shared<MockNetworkConnectionInfoServiceComm>();