Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Miner] Miner should extend its tenure even if it didn't produce the stacks tip when there is an unresponsive sortition winner #5819

Open
jferrant opened this issue Feb 10, 2025 · 0 comments
Milestone

Comments

@jferrant
Copy link
Collaborator

Currently we do not handle the following tenure extend case:

Miner A wins tenure A.
Miner B wins tenure B BEFORE Miner A manages to issue a BlockFound.
Miner B fails to produce a block by Miner A's tenure_extend_wait_timeout
Miner A SHOULD issue a late block found then a tenure extend for tenure A.

Similarly, Miner A wins tenure A.
Flashblocks occur
Miner B wins tenure B BEFORE Miner A manages to issue its late BlockFound.
Miner B fails to produce a block by Miner A's tenure_extend_wait_timeout.
Miner A SHOULD issuea. late block found then a tenure extend for tenure A.

As the code is set up now, Miner A will only consider extending its tenure during a sortition with a winnner if it won the ongoing tenure sortition (i.e. it produced the last stacks block). In the two above scenarios, it has not (since it never produced a block) and therefore just stop its tenure without attempting a delayed tenure start/extend. Fix this and add the above two testing scenarios.

@jferrant jferrant added this to the 3.1.0.0.6 milestone Feb 10, 2025
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Feb 10, 2025
@aldur aldur moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 📋 Backlog
Development

No branches or pull requests

1 participant