Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to re-send saved events if the observer is no longer registered #5822

Open
obycode opened this issue Feb 10, 2025 · 1 comment
Open
Assignees
Milestone

Comments

@obycode
Copy link
Contributor

obycode commented Feb 10, 2025

Problem

  • Event observer X is registered on a stacks-node
  • Event observer X goes down, so the stacks-node is stuck, attempting to successfully send an event to X
  • X is no longer needed, so it is removed from the stacks-node's configuration
  • The event attempted to send to X was recorded in the event_observers.sqlite, so on the next event, the node attempts again to send the event to X

Solution

When processing pending payloads from the database, we should first check if the event observer is still registered for this node. If it is not, just drop the pending payload without attempting to send it.

@obycode
Copy link
Contributor Author

obycode commented Feb 10, 2025

Alternatively, this could be implemented as a cleaning of the pending payloads database on startup (or when the event observers change).

@aldur aldur moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng Feb 12, 2025
@aldur aldur added this to the 3.1.0.0.6 milestone Feb 12, 2025
@hstove hstove moved this from Status: 📋 Backlog to Status: 💻 In Progress in Stacks Core Eng Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 💻 In Progress
Development

No branches or pull requests

3 participants