Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P2P] DropPeer needs to include a port #5837

Open
jcnelson opened this issue Feb 14, 2025 · 1 comment
Open

[P2P] DropPeer needs to include a port #5837

jcnelson opened this issue Feb 14, 2025 · 1 comment
Labels
bug Unwanted or unintended property causing functional harm release-blocking
Milestone
3.1.0.0.6

Comments

@jcnelson
Copy link
Member

When deregistering peers, the new DropPeer functionality will deregister every peer with a given IP address. It needs to additionally consider the port, so nodes with the same IP address are not wholesale dropped. This is what's been causing the P2P convergence CI tests to fail.
@jcnelson jcnelson added bug Unwanted or unintended property causing functional harm release-blocking labels Feb 14, 2025
@jcnelson jcnelson added this to the 3.1.0.0.6 milestone Feb 14, 2025
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Feb 14, 2025
@jcnelson
Copy link
Member Author

This is currently preventing CI from passing, and it would lead to gratuitous P2P disconnections in mainnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unwanted or unintended property causing functional harm release-blocking
Projects
Stacks Core Eng
Status: Status: 🆕 New
Milestone
3.1.0.0.6
Development

No branches or pull requests
1 participant
@jcnelson