[CI] remove `ready_for_review` pr trigger

[fdefelici]

Current Behavior

Our CI workflow is currently triggered by the ready_for_review event, as configured here:

stacks-core/.github/workflows/ci.yml

Lines 17 to 22 in 1015b9f

	pull_request:
	types:
	- opened
	- reopened
	- synchronize
	- ready_for_review

This means that when a pull request is converted from "draft" to "ready" for review, the workflow runs again, even though it has already been executed for the latest commit due to the synchronize trigger.

Proposal

Remove the ready_for_review trigger to:

• Avoid redundant workflow runs and save CI resources
• Ensure that marking a PR as “ready for review” simply presents the existing check results to reviewers, without triggering a new run

@wileyj what’s your take on this change?

[wileyj]

as discussed on the daily - the reason for that trigger is so that if a PR is opened in draft mode iniitally, when it is converted to "ready for review", the status checks will run.
otherwise, it would require either an approval (without status checks passing), or a new commit to the branch to trigger the status checks.

i can't think of an automated way to replicate this while also removing ready_for_review.
however, the number of PR's opened initially in draft mode (more common is that that they're moved to draft for various reasons) is quite small - so this would only apply to very small set of PR's.

I don't have an opinion on if this trigger should stay or go - but if it's causing issues for core devs, we can definitely remove it and will just need to be aware of the above scenario.

[fdefelici]

I made a specific test on "mercury-vale" repo.
It seems that opening a PR in draft using the Draft Pull Request button, trigger the CI workflow anyway.
This should be because of synchronize (edit: I meant opened) event .

Here the evidence: stacks-network/mercury-vale#16

So, if I'm not mistaken somehow, there is no special case to handle. We could safetly remove the ready_for_review trigger.

[wileyj]

I made a specific test on "mercury-vale" repo. It seems that opening a PR in draft using the Draft Pull Request button, trigger the CI workflow anyway. This should be because of synchronize event .

Here the evidence: stacks-network/mercury-vale#16

So, if I'm not mistaken somehow, there is no special case to handle. We could safetly remove the ready_for_review trigger.

interesting - good to know!
in that case, yea - let's remove it. worst case, we add it back in later

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.