Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Comments #35

Closed
pjhartzell opened this issue Oct 7, 2022 · 0 comments · Fixed by #36
Closed

Review Comments #35

pjhartzell opened this issue Oct 7, 2022 · 0 comments · Fixed by #36

Comments

@pjhartzell
Copy link

Quite the project! 🙂 I looked around much of the project, but am limiting my comments to what I see in the Items and Collections:

  1. Is it worth adding something like source to the roles of the NetCDF assets that are on the collections?
  2. Use of an average datetime (e.g., middle of a year) instead of setting it to null: is that the recommended practice? I've been avoiding setting datetime for long time period data since the data is not necessarily representative of state as of a single date.
  3. Any opinions on use of singular rather than plural for units? For example, degree Celsius versus degrees Celsius.
  4. spatial resolution in raster:bands?
  5. sci:citation on the collections: fill in or delete: [indicate subset used] and Accessed [date]
@gadomski gadomski mentioned this issue Oct 7, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant