Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eigen logistic function for inv_logit #3154

Closed
jachymb opened this issue Feb 26, 2025 · 1 comment
Closed

Use eigen logistic function for inv_logit #3154

jachymb opened this issue Feb 26, 2025 · 1 comment

Comments

@jachymb
Copy link

jachymb commented Feb 26, 2025

There is the following comment int prim/fun/inv_logit.hpp from Jan 8 2020

// TODO(Tadej): Eigen is introducing their implementation logistic() of this
// in 3.4. Use that once we switch to Eigen 3.4

We use Eigen 3.4 since Mar 10 2023 and there is in fact a logistic function available: https://eigen.tuxfamily.org/dox/namespaceEigen.html#title47

so this would simplify code and perhaps perform a bit better?

@jachymb
Copy link
Author

jachymb commented Mar 18, 2025

Apparently solved with #3160

@jachymb jachymb closed this as completed Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants