Merge pull request #402 from n-kall/tail-length-fix

properly take into account r_eff when deciding tail length

Author: avehtari

R/pareto_smooth.R

@@ -639,7 +639,12 @@ ps_convergence_rate <- function(k, ndraws, ...) {
 #' @return tail length
 #' @export
 ps_tail_length <- function(ndraws, r_eff, ...) {
-  ceiling(ifelse(ndraws > 225, 3 * sqrt(ndraws / r_eff), ndraws / 5))
+  floor(
+    ifelse(
+      ndraws * r_eff > 225,
+      3 * sqrt(ndraws / r_eff),
+      ndraws / 5)
+  )
 }
 
 #' Pareto-k diagnostic message