You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It occurred to me I could script these changes pretty easily using a bulk-regex command I've had for a bit. I've run through the corpus making the changes for DPC and they look good. The command gives me a list of which repositories are changed, so scripting the commits should be equally as easy. Making the changes for DP (pgdp.net) and Faded Page* should be equally as easy (I assume you want this as three different commits.)
I also assume we don't want to update the corpus until the version of the utilities is released that contains the new lint checks (including the change for DP that I'll PR tomorrow). Absolutely no rush, a week, a month, or whenever you're in the neighborhood of being ready for the next release, let me know and I'll plan to make all of the changes the day before release? Or the day of? Whenever you would like them made.
Note this is only changing the description of DPC and DP wherever they exist; it is not adding them if they're in one place and not the other. That will have to await the additional checks for metadata transcribers vs colophon transcribers if I can figure out how to do that, and judging from sample data with these changes, I think there is going to be quite a bit of cleanup come out of that.
*Lint does not currently have any test for Faded Page. I can add one if you want one, or we can just update all of the existing Faded Page Canada to just Faded Page. That won't keep new ones from getting the wrong value, but there's nothing keeping them consistent now, either—we have a mixture of "Faded Page" and "Faded Page Canada" already.
The text was updated successfully, but these errors were encountered:
It occurred to me I could script these changes pretty easily using a bulk-regex command I've had for a bit. I've run through the corpus making the changes for DPC and they look good. The command gives me a list of which repositories are changed, so scripting the commits should be equally as easy. Making the changes for DP (pgdp.net) and Faded Page* should be equally as easy (I assume you want this as three different commits.)
I also assume we don't want to update the corpus until the version of the utilities is released that contains the new lint checks (including the change for DP that I'll PR tomorrow). Absolutely no rush, a week, a month, or whenever you're in the neighborhood of being ready for the next release, let me know and I'll plan to make all of the changes the day before release? Or the day of? Whenever you would like them made.
Note this is only changing the description of DPC and DP wherever they exist; it is not adding them if they're in one place and not the other. That will have to await the additional checks for metadata transcribers vs colophon transcribers if I can figure out how to do that, and judging from sample data with these changes, I think there is going to be quite a bit of cleanup come out of that.
*Lint does not currently have any test for Faded Page. I can add one if you want one, or we can just update all of the existing Faded Page Canada to just Faded Page. That won't keep new ones from getting the wrong value, but there's nothing keeping them consistent now, either—we have a mixture of "Faded Page" and "Faded Page Canada" already.
The text was updated successfully, but these errors were encountered: