Skip to content

PGDP[Canada] and Faded Page changes #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vr8hub opened this issue Mar 16, 2025 · 1 comment
Open

PGDP[Canada] and Faded Page changes #805

vr8hub opened this issue Mar 16, 2025 · 1 comment

Comments

@vr8hub
Copy link
Contributor

vr8hub commented Mar 16, 2025

It occurred to me I could script these changes pretty easily using a bulk-regex command I've had for a bit. I've run through the corpus making the changes for DPC and they look good. The command gives me a list of which repositories are changed, so scripting the commits should be equally as easy. Making the changes for DP (pgdp.net) and Faded Page* should be equally as easy (I assume you want this as three different commits.)

I also assume we don't want to update the corpus until the version of the utilities is released that contains the new lint checks (including the change for DP that I'll PR tomorrow). Absolutely no rush, a week, a month, or whenever you're in the neighborhood of being ready for the next release, let me know and I'll plan to make all of the changes the day before release? Or the day of? Whenever you would like them made.

Note this is only changing the description of DPC and DP wherever they exist; it is not adding them if they're in one place and not the other. That will have to await the additional checks for metadata transcribers vs colophon transcribers if I can figure out how to do that, and judging from sample data with these changes, I think there is going to be quite a bit of cleanup come out of that.

*Lint does not currently have any test for Faded Page. I can add one if you want one, or we can just update all of the existing Faded Page Canada to just Faded Page. That won't keep new ones from getting the wrong value, but there's nothing keeping them consistent now, either—we have a mixture of "Faded Page" and "Faded Page Canada" already.

@acabal
Copy link
Member

acabal commented Mar 16, 2025

Yes, let's wait until the changes are fully merged in so I don't review a book using out of date tools and then forget to check this by hand.

We could certainly add a test for Faded Page since we're doing all of this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants