apollo_network: changed gossipsub configurations

Author: sirandreww-starkware

crates/apollo_network/src/gossipsub_impl.rs

@@ -23,15 +23,16 @@ impl From<gossipsub::Event> for mixed_behaviour::Event {
                 message: gossipsub::Message { data, topic, source, .. },
                 ..
             } => {
-                let Some(originated_peer_id) = source else {
-                    error!(
-                        "Received a message from gossipsub without source even though we've \
-                         configured it to reject such messages"
-                    );
-                    return mixed_behaviour::Event::ToOtherBehaviourEvent(
-                        mixed_behaviour::ToOtherBehaviourEvent::NoOp,
-                    );
-                };
+                // let Some(originated_peer_id) = source else {
+                //     error!(
+                //         "Received a message from gossipsub without source even though we've \
+                //          configured it to reject such messages"
+                //     );
+                //     return mixed_behaviour::Event::ToOtherBehaviourEvent(
+                //         mixed_behaviour::ToOtherBehaviourEvent::NoOp,
+                //     );
+                // };
+                let originated_peer_id = source.unwrap_or_else(PeerId::random);
                 mixed_behaviour::Event::ExternalEvent(mixed_behaviour::ExternalEvent::GossipSub(
                     ExternalEvent::Received {
                         originated_peer_id,

crates/apollo_network/src/mixed_behaviour.rs

@@ -1,8 +1,10 @@
 // TODO(shahak): Erase main_behaviour and make this a separate module.
 
 use std::convert::Infallible;
+use std::time::Duration;
 
 use libp2p::connection_limits::ConnectionLimits;
+use libp2p::gossipsub::ValidationMode;
 use libp2p::identity::Keypair;
 use libp2p::kad::store::MemoryStore;
 use libp2p::swarm::behaviour::toggle::Toggle;
@@ -81,8 +83,59 @@ impl MixedBehaviour {
             StreamProtocol::try_from_owned(format!("/starknet/kad/{chain_id}/1.0.0"))
                 .expect("Failed to create StreamProtocol from a string that starts with /");
         let kademlia_config = kad::Config::new(protocol_name);
-        let connection_limits = ConnectionLimits::default().with_max_established_per_peer(Some(1));
+        let connection_limits = ConnectionLimits::default(); // .with_max_established_per_peer(Some(1));
 
+        let gossipsub_config = gossipsub::ConfigBuilder::default()
+            .max_transmit_size(1 << 34)
+            .flood_publish(false)
+            .heartbeat_interval(Duration::from_millis(700))
+            .validation_mode(ValidationMode::None)
+            .message_id_fn(|message| {
+                let mut source_string = message.source.as_ref().map(|id| id.to_bytes()).unwrap_or_default();
+                source_string
+                    .extend_from_slice(&message.sequence_number.unwrap_or_default().to_be_bytes());
+                source_string.extend_from_slice(&message.data[0..16]);
+                gossipsub::MessageId::from(source_string)
+            })
+
+            
+            // .max_messages_per_rpc(Some(1))
+            .history_length(5)
+
+            // .connection_handler_queue_len(50_000) 
+
+            .mesh_n(99)          // Target mesh peers
+            .mesh_n_low(99)       // Minimum before adding (default: 5)
+            .mesh_n_high(99)     // Maximum before pruning (default
+            // .publish_queue_duration(Duration::from_millis(500))  // default: 5s
+            // .forward_queue_duration(Duration::from_millis(100))  // default: 1s
+    
+
+            // .heartbeat_interval(Duration::from_millis(200))
+            // Set gossip_lazy to 0 - minimum number of peers to gossip to
+            .gossip_lazy(0)
+
+            // Set gossip_factor to 0.0 - factor for dynamic gossip peer selection
+            .gossip_factor(0.0)
+
+            // Set history_gossip to 0 - number of past heartbeats to gossip about
+            .history_gossip(0)
+
+            // Optional: Set max_ihave_length to 0 - maximum IHAVE message IDs per message
+            .max_ihave_length(0)
+
+            // Optional: Set max_ihave_messages to 0 - maximum IHAVE messages per heartbeat
+            .max_ihave_messages(0)
+
+            // Optional: Set gossip_retransmission to 0 - disable IWANT retries
+            .gossip_retransimission(0)
+            
+            // Enable IDONTWANT optimization
+            // .idontwant_message_size_threshold(1000)  // Adjust based on your message sizes
+            .idontwant_on_publish(true)              // Prevent echo-back on publish
+   
+            .build()
+            .expect("Failed to build gossipsub config");
         Self {
             limits: connection_limits::Behaviour::new(connection_limits),
             peer_manager: peer_manager::PeerManager::new(peer_manager_config),
@@ -123,12 +176,8 @@ impl MixedBehaviour {
             ),
             sqmr: sqmr::Behaviour::new(streamed_bytes_config),
             gossipsub: gossipsub::Behaviour::new(
-                gossipsub::MessageAuthenticity::Signed(keypair),
-                gossipsub::ConfigBuilder::default()
-                    // TODO(shahak): try to reduce this bound.
-                    .max_transmit_size(1 << 34)
-                    .build()
-                    .expect("Failed to build gossipsub config"),
+                gossipsub::MessageAuthenticity::Author(local_peer_id),
+                gossipsub_config,
             )
             .unwrap_or_else(|err_string| {
                 panic!(