Skip to content

Commit 6565a7d

Browse files
apollo_dashboard: add new module queries_builder
1 parent 8a7a038 commit 6565a7d

File tree

3 files changed

+27
-0
lines changed

3 files changed

+27
-0
lines changed

crates/apollo_dashboard/src/lib.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,7 @@ pub mod dashboard_definitions;
66
#[cfg(test)]
77
mod metric_definitions_test;
88
mod panels;
9+
10+
// TODO(MatanL): Remove cfg(test) when used
11+
#[cfg(test)]
12+
mod query_builder;
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
use apollo_metrics::metrics::MetricCommon;
2+
3+
#[cfg(test)]
4+
#[path = "query_builder_test.rs"]
5+
pub mod query_builder_test;
6+
7+
pub(crate) fn increase(metric: &dyn MetricCommon, duration: &str) -> String {
8+
format!("increase({}[{}])", metric.get_name_with_filter(), duration)
9+
}
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
use apollo_infra_utils::template::Template;
2+
use apollo_metrics::metric_label_filter;
3+
use apollo_metrics::metrics::{MetricGauge, MetricScope};
4+
5+
use crate::query_builder;
6+
7+
#[test]
8+
fn increase_formats_correctly() {
9+
let m = MetricGauge::new(MetricScope::Batcher, "testing", "Fake description");
10+
let q = query_builder::increase(&m, "5m");
11+
let expected =
12+
Template::new("increase({}{}[{}])").format(&[&"testing", &metric_label_filter!(), &"5m"]);
13+
assert_eq!(q, expected);
14+
}

0 commit comments

Comments
 (0)