apollo_network: no blacklisting on unstable connection

sirandreww-starkware · sirandreww-starkware · commit cefbfb443323 · 2025-10-30T11:33:16.000+02:00
diff --git a/crates/apollo_network/src/peer_manager/mod.rs b/crates/apollo_network/src/peer_manager/mod.rs
@@ -226,9 +226,9 @@ impl PeerManager {
                     }
                 }
                 ReputationModifier::Unstable => {
-                    self.pending_events.push(ToSwarm::GenerateEvent(
-                        ToOtherBehaviourEvent::PeerBlacklisted { peer_id },
-                    ));
+                    // self.pending_events.push(ToSwarm::GenerateEvent(
+                    //     ToOtherBehaviourEvent::PeerBlacklisted { peer_id },
+                    // ));
                     peer.blacklist_peer(self.config.unstable_timeout_millis);
                 }
             }
diff --git a/crates/apollo_network/src/peer_manager/peer.rs b/crates/apollo_network/src/peer_manager/peer.rs
@@ -27,7 +27,7 @@ impl Peer {
     }
 
     pub fn blacklist_peer(&mut self, timeout_duration: Duration) {
-        self.timed_out_until = get_instant_now() + timeout_duration;
+        // self.timed_out_until = get_instant_now() + timeout_duration;
         info!(
             "Peer {:?} misbehaved. Blacklisting it for {:.3} seconds.",
             self.peer_id,

Original file line number	Diff line number	Diff line change
`@@ -226,9 +226,9 @@ impl PeerManager {`
`226`	`226`	`}`
`227`	`227`	`}`
`228`	`228`	`ReputationModifier::Unstable => {`
`229`		`- self.pending_events.push(ToSwarm::GenerateEvent(`
`230`		`- ToOtherBehaviourEvent::PeerBlacklisted { peer_id },`
`231`		`- ));`
	`229`	`+ // self.pending_events.push(ToSwarm::GenerateEvent(`
	`230`	`+ // ToOtherBehaviourEvent::PeerBlacklisted { peer_id },`
	`231`	`+ // ));`
`232`	`232`	`peer.blacklist_peer(self.config.unstable_timeout_millis);`
`233`	`233`	`}`
`234`	`234`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ impl Peer {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`pub fn blacklist_peer(&mut self, timeout_duration: Duration) {`
`30`		`- self.timed_out_until = get_instant_now() + timeout_duration;`
	`30`	`+ // self.timed_out_until = get_instant_now() + timeout_duration;`
`31`	`31`	`info!(`
`32`	`32`	`"Peer {:?} misbehaved. Blacklisting it for {:.3} seconds.",`
`33`	`33`	`self.peer_id,`