code review

Author: abakst

CodeHawk/CHC/cchanalyze/Makefile

@@ -56,6 +56,7 @@ MLIS := \
 	cCHPOCheckCast \
 	cCHPOCheckCommonBase \
 	cCHPOCheckCommonBaseType \
+	cCHPOCheckErrnoWritten \
 	cCHPOCheckControlledResource \
 	cCHPOCheckFormatCast \
 	cCHPOCheckInScope \

CodeHawk/CHC/cchanalyze/cCHFunctionTranslator.ml

@@ -381,7 +381,7 @@ object
     let fsymbol = EU.symbol f.svar.vname in
     let proc =
       EU.mkProcedure fsymbol ~signature:[] ~bindings:[] ~scope ~body:fbody in
-    let _ = CHPretty.pr_debug [proc#toPretty; NL; NL] in
+    (* let _ = CHPretty.pr_debug [proc#toPretty; NL; NL] in *)
     let csystem = EU.mkSystem (new symbol_t "c-system") in
     let _ = csystem#addProcedure proc in
     (None, csystem)

CodeHawk/CHC/cchanalyze/cCHPOCheckErrnoWritten.mli

@@ -0,0 +1,34 @@
+(* =============================================================================
+   CodeHawk C Analyzer
+   Author: Alexander Bakst
+   ------------------------------------------------------------------------------
+   The MIT License (MIT)
+
+   Copyright (c) 2026      Aarno Labs LLC
+
+   Permission is hereby granted, free of charge, to any person obtaining a copy
+   of this software and associated documentation files (the "Software"), to deal
+   in the Software without restriction, including without limitation the rights
+   to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+   copies of the Software, and to permit persons to whom the Software is
+   furnished to do so, subject to the following conditions:
+
+   The above copyright notice and this permission notice shall be included in all
+   copies or substantial portions of the Software.
+
+   THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+   IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+   FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+   AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+   LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+   OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+   SOFTWARE.
+   ============================================================================= *)
+
+(* cchanalyze *)
+open CCHAnalysisTypes
+
+(* cchpre *)
+open CCHPreTypes
+
+val check_errno_written : po_query_int -> location_invariant_int -> bool

CodeHawk/CHC/cchlib/cCHSumTypeSerializer.ml

@@ -428,7 +428,7 @@ object
     | XExternalStateValue _ -> "esv"
     | XFormattedInput _ -> "fi"
     | XFalse -> "f"
-    | XWritesErrno -> "we" (* ?? *)
+    | XWritesErrno -> "ew"
     | XFreed _ -> "fr"
     | XFunctional -> "fn"
     | XGlobalAddress _ -> "ga"