Move release constants to release/

I don't want anything defined in root
constants.php because I have rector doing some
aggressive dead code elimination based on those
constants.

- Move wp-org/constants.php to release/wp-org/...
- Move constants.php to release/github/... and
  leave root constants.php with no defs.
- Update flake.nix to use these new paths

This lets the GitHub build do dead code
elimination to remove unneeded WP functions.

Author: john-shaffer

constants.php

@@ -7,11 +7,3 @@
  * in order to remove code entirely at build-time if
  * a feature is disabled.
  */
-
-// Disable the use of functions that wordpress.org requires
-// but we would not use when we aren't forced to.
-// e.g. using wp_rand instead of mt_rand in a context
-// where a CSPRNG adds no value.
-// This is just to enable useless functions, not WP
-// functions that do serve some purpose.
-define( 'STATIC_DEPLOY_WP_ORG_MODE', false );

flake.nix

@@ -46,12 +46,12 @@
             && pkgs.lib.hasSuffix ".php" base || base == "composer.json" || base
             == "composer.lock" || base == "phpcs.xml" || base == "phpunit.xml";
         };
-        wpOrgExtras = pkgs.lib.cleanSourceWith {
+        releaseExtras = pkgs.lib.cleanSourceWith {
           src = self;
           filter = path: type:
             let base = baseNameOf path;
-            in type == "directory" && base == "wp-org"
-            || pkgs.lib.hasInfix "/wp-org/" path;
+            in type == "directory" && base == "release"
+            || pkgs.lib.hasInfix "/release/" path;
         };
         buildStaticDeploySrc = constantsFile:
           runCommand "static-deploy-source" {
@@ -74,9 +74,9 @@
             cp -r composer.json src static-deploy.php uninstall.php vendor views "$out"
           '';
         staticDeployWpOrgSrc =
-          buildStaticDeploySrc "${wpOrgExtras}/wp-org/constants.php";
+          buildStaticDeploySrc "${releaseExtras}/release/wp-org/constants.php";
         staticDeployGitHubSrc =
-          buildStaticDeploySrc "${staticDeploySrc}/constants.php";
+          buildStaticDeploySrc "${releaseExtras}/release/github/constants.php";
         pluginZip = source:
           runCommand name { } ''
             mkdir "$TMPDIR/${name}"

release/github/constants.php

@@ -0,0 +1,17 @@
+<?php
+/**
+ * This file can be added to in order to force
+ * rector to use certain values for constants.
+ * This is mainly used in statements like
+ * if ( FEATURE_ENABLED ) { ... }
+ * in order to remove code entirely at build-time if
+ * a feature is disabled.
+ */
+
+// Disable the use of functions that wordpress.org requires
+// but we would not use when we aren't forced to.
+// e.g. using wp_rand instead of mt_rand in a context
+// where a CSPRNG adds no value.
+// This is just to enable useless functions, not WP
+// functions that do serve some purpose.
+define( 'STATIC_DEPLOY_WP_ORG_MODE', false );