Merge pull request #136 from statsig-io/evaluatepartial

tore-statsig · web-flow · commit 19389233b0fe · 2023-02-06T16:41:22.000-08:00
Properly evaluate fractional pass percentages
diff --git a/src/main/kotlin/com/statsig/sdk/Evaluator.kt b/src/main/kotlin/com/statsig/sdk/Evaluator.kt
@@ -236,7 +236,7 @@ internal class Evaluator(
                             '.' +
                             (getUnitID(user, rule.idType) ?: "")
                     )
-                        .mod(10000UL) < rule.passPercentage.toULong().times(100UL)
+                        .mod(10000UL) < (rule.passPercentage.times(100.0)).toULong()
 
                 return ConfigEvaluation(
                     false,

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ internal class Evaluator(`
`236`	`236`	`'.' +`
`237`	`237`	`(getUnitID(user, rule.idType) ?: "")`
`238`	`238`	`)`
`239`		`- .mod(10000UL) < rule.passPercentage.toULong().times(100UL)`
	`239`	`+ .mod(10000UL) < (rule.passPercentage.times(100.0)).toULong()`
`240`	`240`
`241`	`241`	`return ConfigEvaluation(`
`242`	`242`	`false,`