Decouple Codex reset-credit expiry display from “Show credits + extra usage”

[simon-ami]

Problem

Codex reset-credit availability and expiry are currently hidden when Settings → Display → Show credits + extra usage is disabled.

That toggle is useful for hiding optional credit/extra-usage sections, but reset-credit expiry is different: it is time-sensitive operational information. If a user turns off credits/extra usage to keep the menu cleaner, they can also lose visibility into whether they have manual Codex resets available and when the next one expires.

Current behavior

1. Enable Codex as a provider.

2. Have at least one available Codex rate-limit reset credit.

3. Open the CodexBar menu with Show credits + extra usage enabled.

4. The menu shows the reset-credit section, e.g.:

   • Limit Reset Credits
   • 1 manual reset available
   • Next expires …

5. Disable Settings → Display → Show credits + extra usage.

6. The reset-credit availability/expiry section disappears too.

Expected behavior

Codex reset-credit expiry should not be coupled to the generic credits/extra-usage toggle.

Preferred behavior:

• Always show Codex reset-credit availability/expiry when reset credits are available.

Alternative acceptable behavior:

• Add a separate Display setting, e.g. Show Codex reset credits or Show reset-credit expirations, defaulting to enabled.

Why this matters

Manual reset credits can expire. Hiding their expiration together with optional credits/extra-usage makes it easy to miss a reset that should be used before it expires.

The reset-credit section feels closer to quota/reset visibility than to optional spend/credit details. Users may reasonably want to hide credit balances and extra usage while still seeing whether they have expiring reset credits.

Code context

The coupling appears to come from the reset-credit model helpers:

• UsageMenuCardView.Model.codexResetCreditsText(input:)
• UsageMenuCardView.Model.codexResetCreditsDetailText(input:)

Both currently guard on input.showOptionalCreditsAndExtraUsage.

There is also a focused test covering the current behavior:

• CodexResetCreditsMenuCardTests
• reset credits hide with optional usage disabled

So the change would likely involve either:

1. removing the showOptionalCreditsAndExtraUsage guard from the reset-credit text/detail helpers and updating the test expectations, or
2. introducing a dedicated reset-credit display setting and covering both toggles independently.

Suggested labels

• enhancement
• area:ui-ux
• provider:codex
• priority:low or priority:medium

[clawsweeper]

Codex review: keeping this open for maintainer follow-up; there is still a little grit to resolve. Reviewed June 25, 2026, 5:19 PM ET / 21:19 UTC.

Summary
Keep open: current main still hides Codex reset-credit availability and expiry behind the optional credits/extra-usage toggle, so the requested decoupling is not implemented. The source path is clear, but maintainers should choose between the preferred always-show behavior and the alternative separate display setting before automation changes user-visible settings policy.

Reproducibility: yes. from source inspection: both reset-credit helpers still guard on showOptionalCreditsAndExtraUsage, and the focused model test asserts nil reset-credit text when the toggle is disabled. I did not run live UI because AGENTS.md favors model seams for this menu behavior unless AppKit wiring itself is under test.

Next step
The code path and test seam are clear, but the choice between always-show behavior and adding a separate display setting is product policy rather than a strict bug fix.

Review details

Best possible solution:

Pick the display policy, then update the reset-credit model helpers and focused tests so expiring manual reset credits remain visible under that policy.

Do we have a high-confidence way to reproduce the issue?

Yes from source inspection: both reset-credit helpers still guard on showOptionalCreditsAndExtraUsage, and the focused model test asserts nil reset-credit text when the toggle is disabled. I did not run live UI because AGENTS.md favors model seams for this menu behavior unless AppKit wiring itself is under test.

Is this the best way to solve the issue?

Unclear until maintainers choose the product policy. Removing the guard is the narrowest implementation for the preferred behavior, while a separate default-on setting is a larger settings-surface choice.

AGENTS.md: found and applied where relevant.

Remaining risk / open question:

• The remaining policy choice is user-visible: always showing available reset credits is narrow, while a separate default-on toggle adds settings surface and localization work.

Codex review notes: model internal, reasoning high; reviewed against ada3660e9d61.

Label changes

Label changes:

• add P3: This is a low-risk UI/UX improvement for a time-sensitive Codex menu detail, not an urgent broken workflow.
• add impact:other: The issue affects visibility of expiring Codex reset credits, which is meaningful maintainer-visible UI impact outside the specific owned impact categories.
• add issue-rating: 🦞 diamond lobster: Current issue advisory state selects this label.
• add clawsweeper:source-repro: Current issue advisory state selects this label.
• add clawsweeper:no-new-fix-pr: Current issue advisory state selects this label.
• add clawsweeper:fix-shape-clear: Current issue advisory state selects this label.
• add clawsweeper:needs-maintainer-review: Current issue advisory state selects this label.
• add clawsweeper:needs-product-decision: Current issue advisory state selects this label.

Label justifications:

• P3: This is a low-risk UI/UX improvement for a time-sensitive Codex menu detail, not an urgent broken workflow.
• impact:other: The issue affects visibility of expiring Codex reset credits, which is meaningful maintainer-visible UI impact outside the specific owned impact categories.

Evidence reviewed

Acceptance criteria:

• swift test --filter CodexResetCreditsMenuCardTests
• swift test --filter MenuCardHeightFingerprintTests
• make check

What I checked:

• Current helper guard: Both Codex reset-credit model helpers require input.showOptionalCreditsAndExtraUsage, so disabling the generic optional usage setting suppresses the reset-credit row and its expiry detail. (Sources/CodexBar/MenuCardView+CodexResetCredits.swift:40, ada3660e9d61)
• Focused test asserts current coupling: The existing reset credits hide with optional usage disabled test constructs reset credits with showOptionalUsage: false and expects both reset-credit strings to be nil. (Tests/CodexBarTests/CodexResetCreditsMenuCardTests.swift:47, ada3660e9d61)
• Menu model passes the shared display setting: The status menu model input receives self.settings.showOptionalCreditsAndExtraUsage, which is the same settings toggle exposed in the Display preferences pane. (Sources/CodexBar/StatusItemController+MenuCardModel.swift:111, ada3660e9d61)
• Preferences surface confirms the toggle: Display settings bind show_credits_extra_usage_title to settings.showOptionalCreditsAndExtraUsage, matching the issue's described UI toggle. (Sources/CodexBar/PreferencesDisplayPane.swift:112, ada3660e9d61)
• History provenance for current behavior: Blame attributes the guarded reset-credit helper implementation to the v0.37.2 release commit, and git log -S finds the same commit introducing this symbol into the checked-out history. (Sources/CodexBar/MenuCardView+CodexResetCredits.swift:42, f380287041b8)
• Related merged feature PR: The merged reset-credit display PR described the feature as rendering reset counts and expiry while respecting optional-usage preferences, which matches the behavior now being refined. (a3ea16743560)

Likely related people:

• steipete: Current-main blame maps the reset-credit helper guard and focused test to the v0.37.2 release commit, and GitHub maps that commit to this account. (role: recent area contributor and release owner; confidence: high; commits: f380287041b8, 57170e008edb; files: Sources/CodexBar/MenuCardView+CodexResetCredits.swift, Tests/CodexBarTests/CodexResetCreditsMenuCardTests.swift)
• rogdex24: Authored the merged reset-credit display PR that introduced the reset-credit menu row, expiry text, and focused tests that this issue now asks to refine. (role: feature implementer; confidence: high; commits: a3ea16743560, 1ae28cfd50eb, 64bf84def52b; files: Sources/CodexBar/MenuCardView+CodexResetCredits.swift, Tests/CodexBarTests/CodexResetCreditsMenuCardTests.swift, Sources/CodexBarCore/Providers/Codex/CodexOAuth/CodexOAuthUsageFetcher.swift)

How this review workflow works

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.