Add a leeway arg for the fee

[kalepail]

I'm getting a ton of timeouts with the CLI due to the fee not being sufficiently higher than the base so the tx just keeps getting punted to the next ledger but never being included (thanks $KALE 🙄)

% stellar contract invoke --id CAK6Z6KFMB3V2ENEJ7THVKXUYQ5EG7EL2TM5UQ2FLDXI37FS6DRIMIZH --source rich -- add_game --id CDB6IODG5BNNVILLJXBXYZVR7NP4HDO2NL7WALWIXGIDMA6VY4V75CEX
ℹ️  Signing transaction: d7787e6b6423cdad1944763384cab2a905b44add08ad248258a3c4d4cab011b3
❌ error: transaction submission timeout
% stellar contract invoke --id CAK6Z6KFMB3V2ENEJ7THVKXUYQ5EG7EL2TM5UQ2FLDXI37FS6DRIMIZH --source rich -- add_game --id CDB6IODG5BNNVILLJXBXYZVR7NP4HDO2NL7WALWIXGIDMA6VY4V75CEX
ℹ️  Signing transaction: d7787e6b6423cdad1944763384cab2a905b44add08ad248258a3c4d4cab011b3
❌ error: transaction submission timeout

I can hardcode a --fee but that's too brute force. I'd prefer to be able to make an additive fee to the simulated fee vs just overwriting it.

Another fix you should consider is using the fee endpoint of the RPC to be smarter about what fee to use. Use p50 or even higher to get past the base fee Launchtube is using.

[tupui]

💯 We also had people complaining about that during the hackathon.

[mootz12]

Would it make sense to just have a configurable inclusion fee? e.g. add an inclusion-fee arg that could also be set w/ env vars. If it exists, we just set fee = inclusion + resource.

To be honest, fee might already do this, but I'd need to verify the behavior.

[kalepail]

Probably would? Again all I care about is getting transactions onchain and whatever default we have right now...that's not happening. So the right fix is probably twofold. Get the default to work better then change --fee or add to it to be less brute force

[kalepail]

If it's helpful this also hits when uploading wasms

% stellar contract upload --wasm target/wasm32v1-none/release/blendizzard.optimized.wasm --source rich
ℹ️  Simulating install transaction…
ℹ️  Signing transaction: 007e54ad08d69df6372859404179d9b6bb67abb01b187d08831560a425f86e2c
🌎 Submitting install transaction…
❌ error: transaction submission failed: TxInsufficientFee

[mootz12]

@kalepail --fee does in fact just apply the inclusion fee, thus, you can include --fee 2000 (or 10000!) by default. It will only pull from the inclusion fee as necessary. Will update documentation here at least, but this might be sufficient enough.

IMO we shouldn't increase fee amounts without some acknowledgement or permission from the user. However, I'm not opposed to seeing options like --fee p90 where we dynamically fetch fee stats and apply p90 as the inclusion fee.

[mootz12]

A possible addition we could make is allowing the network object have an optional fee property, and allow users to set default fee values per network. --fee would override this, but something like

stellar network set-fee mainnet p90

or

stellar network set-fee mainnet 10000

would allow for this not to become a default arg only mainnet transactions need. I'd be hesitant to update the default value of 100 as well as this is extremely common across all Stellar tx builders.

[tupui]

I don't know about that in terms of API. I think having it fail and tell me exactly why and what fees would be needed at least and how to adjust that would be clearer than having some blanket p90. I would always prefer to set a max absolute value.