Skip to content

Commit 2a2816f

Browse files
authored
Merge pull request #653 from stenciljs/gm/review-publish-npm-ga
chore(npm): Update release npm action to stop using tokens
2 parents 9951ab9 + b4e6573 commit 2a2816f

File tree

5 files changed

+60
-62
lines changed

5 files changed

+60
-62
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,24 @@ jobs:
1010
name: Build Stencil Sass
1111
runs-on: 'ubuntu-latest'
1212
steps:
13-
- name: Checkout Code
13+
- name: 📥 Checkout Code
1414
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
1515
with:
1616
# the pull_request_target event will consider the HEAD of `main` to be the SHA to use.
1717
# attempt to use the SHA associated with a pull request and fallback to HEAD of `main`
1818
ref: ${{ github.event_name == 'pull_request_target' && format('refs/pull/{0}/merge', github.event.number) || '' }}
1919
persist-credentials: false
2020

21-
- name: Get Core Dependencies
21+
- name: 🕸️ Get Core Dependencies
2222
uses: stenciljs/.github/actions/get-core-dependencies@main
2323

24-
- name: Stencil Sass Build
24+
- name: 🏗️ Stencil Sass Build
2525
run: npm run build
2626
shell: bash
2727

28-
- name: Unit Tests
28+
- name: 🧪 Unit Tests
2929
run: npm test
3030
shell: bash
3131

32-
- name: Upload Build Artifacts
32+
- name: 📤 Upload Build Artifacts
3333
uses: stenciljs/.github/actions/upload-archive@main

.github/workflows/main.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,31 +27,31 @@ jobs:
2727
runs-on: ubuntu-latest
2828

2929
steps:
30-
- name: Checkout Code
30+
- name: 📥 Checkout Code
3131
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3232
with:
3333
persist-credentials: false
3434

35-
- name: Get Core Dependencies
35+
- name: 🕸️ Get Core Dependencies
3636
uses: stenciljs/.github/actions/get-core-dependencies@main
3737

38-
- name: Prettier Check
38+
- name: 📝 Prettier Check
3939
run: npm run prettier.dry-run
4040
shell: bash
4141

42-
- name: Install Stencil ${{matrix.stencil_version}}
42+
- name: 📦 Install Stencil ${{matrix.stencil_version}}
4343
run: npm install --save-dev @stencil/core@${{matrix.stencil_version}}
4444
shell: bash
4545
if: ${{ matrix.stencil_version != 'DEFAULT' }}
4646

47-
- name: Report Stencil Version
47+
- name: 📊 Report Stencil Version
4848
run: npm ls @stencil/core
4949
shell: bash
5050

51-
- name: Build
51+
- name: 🏗️ Build
5252
run: npm run build -- --ci
5353
shell: bash
5454

55-
- name: Test
55+
- name: 🧪 Test
5656
run: npm run test.ci
5757
shell: bash

.github/workflows/release.yml

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,20 @@ on:
2323

2424
jobs:
2525
build_stencil_sass:
26-
name: Build
26+
name: 🏗️ Build Stencil Sass
2727
uses: ./.github/workflows/build.yml
2828

2929
get_dev_version:
3030
if: inputs.devRelease == 'yes'
31-
name: Get Dev Build Version
31+
name: 🔍 Get Dev Build Version
3232
runs-on: ubuntu-latest
3333
outputs:
3434
dev-version: ${{ steps.generate-dev-version.outputs.DEV_VERSION }}
3535
steps:
36-
- name: Checkout Code
36+
- name: 📥 Checkout Code
3737
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3838

39-
- name: Generate Dev Version
39+
- name: ⚙️ Generate Dev Version
4040
id: generate-dev-version
4141
run: |
4242
PKG_JSON_VERSION=$(cat package.json | jq -r '.version')
@@ -55,34 +55,32 @@ jobs:
5555

5656
release_sass_stencil:
5757
if: inputs.devRelease == 'yes'
58-
name: Publish Dev Build
58+
name: 📦 Publish Dev Build
5959
needs: [build_stencil_sass, get_dev_version]
6060
runs-on: ubuntu-latest
6161
permissions:
6262
id-token: write
6363
steps:
64-
- name: Checkout Code
64+
- name: 📥 Checkout Code
6565
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
66-
- uses: stenciljs/.github/actions/publish-npm@main
66+
- uses: stenciljs/.github/actions/publish-npm@e9945bdf51e97eee158513427ecf7be3d3a80443 # temp fix for trusted publishers
6767
with:
6868
tag: dev
6969
version: ${{ needs.get_dev_version.outputs.dev-version }}
70-
token: ${{ secrets.NPM_PAT_STENCIL_BOT }}
7170

7271
release_create_stencil_cli:
7372
if: inputs.devRelease == 'no'
74-
name: Publish Stencil Store
73+
name: 📦 Publish Stencil Store
7574
needs: [build_stencil_sass]
7675
runs-on: ubuntu-latest
7776
permissions:
7877
contents: write
7978
id-token: write
8079
steps:
81-
- name: Checkout Code
80+
- name: 📥 Checkout Code
8281
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
83-
- uses: stenciljs/.github/actions/publish-npm@main
82+
- uses: stenciljs/.github/actions/publish-npm@e9945bdf51e97eee158513427ecf7be3d3a80443 # temp fix for trusted publishers
8483
with:
8584
tag: latest
8685
version: ${{ inputs.releaseType }}
87-
token: ${{ secrets.NPM_PAT_STENCIL_BOT }}
88-
github-token: ${{ secrets.GH_ADMIN_PAT }}
86+
github-token: ${{ secrets.GITHUB_TOKEN }}

package-lock.json

Lines changed: 25 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"scripts": {
1616
"prebuild": "rimraf ./dist",
1717
"prettier": "npm run prettier.base -- --write",
18-
"prettier.base": "prettier --cache 'src/**/*.ts'",
18+
"prettier.base": "prettier --cache \"src/**/*.ts\"",
1919
"prettier.dry-run": "npm run prettier.base -- --list-different",
2020
"build": "npm run prebuild && npm run rollup",
2121
"watch": "npm run rollup -- --watch",
@@ -27,26 +27,26 @@
2727
"test.watch": "jest --watch"
2828
},
2929
"dependencies": {
30-
"sass-embedded": "^1.89.2"
30+
"sass-embedded": "^1.93.2"
3131
},
3232
"peerDependencies": {
3333
"@stencil/core": ">=2.0.0 || >=3.0.0-beta.0 || >= 4.0.0-beta.0 || >= 4.0.0"
3434
},
3535
"devDependencies": {
3636
"@ionic/prettier-config": "^4.0.0",
37-
"@rollup/plugin-node-resolve": "^16.0.1",
38-
"@rollup/plugin-typescript": "^12.1.3",
39-
"@stencil/core": "^4.35.1",
37+
"@rollup/plugin-node-resolve": "^16.0.3",
38+
"@rollup/plugin-typescript": "^12.3.0",
39+
"@stencil/core": "^4.38.2",
4040
"@types/jest": "^30.0.0",
41-
"@types/node": "^22.13.8",
42-
"jest": "^30.0.2",
41+
"@types/node": "^24.9.2",
42+
"jest": "^30.2.0",
4343
"np": "^10.2.0",
44-
"prettier": "^3.6.0",
44+
"prettier": "^3.6.2",
4545
"rimraf": "^6.0.1",
46-
"rollup": "^4.44.0",
47-
"terser": "^5.43.1",
48-
"ts-jest": "^29.4.0",
49-
"typescript": "~5.9.2"
46+
"rollup": "^4.52.5",
47+
"terser": "^5.44.0",
48+
"ts-jest": "^29.4.5",
49+
"typescript": "~5.9.3"
5050
},
5151
"repository": {
5252
"type": "git",

0 commit comments

Comments
 (0)