Lint clean

Signed-off-by: Guangguan Wang <[email protected]>

Author: GuangguanWang

src/rdma_provider.h

@@ -18,11 +18,12 @@
 
 #ifdef DMLC_USE_RDMA
 
-#include <string>
 #include <rdma/rdma_cma.h>
 
-#include "dmlc/logging.h"
+#include <string>
+
 #include "./ibvwarp.h"
+#include "dmlc/logging.h"
 
 namespace ps {
 
@@ -31,14 +32,14 @@ class RDMAProvider {
   static RDMAProvider *GetProvider(struct ibv_context *context);
 
   virtual int InlineSize() = 0;
-  virtual int SetQPLag(struct ibv_qp* qp, int port_num) = 0;
+  virtual int SetQPLag(struct ibv_qp *qp, int port_num) = 0;
   virtual int ErrIgnore(struct ibv_wc *wc) = 0;
 
  protected:
   RDMAProvider() {}
 };
 
-class eRDMAProvider: public RDMAProvider {
+class eRDMAProvider : public RDMAProvider {
  public:
   static inline RDMAProvider *Get() {
     static RDMAProvider *inst_ptr = new eRDMAProvider();
@@ -62,12 +63,11 @@ class eRDMAProvider: public RDMAProvider {
   }
 
  private:
-  explicit eRDMAProvider() {}
+  eRDMAProvider() {}
 };
 
-class Mlx5Provider: public RDMAProvider {
+class Mlx5Provider : public RDMAProvider {
  public:
-
   static inline RDMAProvider *Get() {
     static RDMAProvider *inst_ptr = new Mlx5Provider();
     return inst_ptr;
@@ -94,7 +94,7 @@ class Mlx5Provider: public RDMAProvider {
   }
 
  private:
-  explicit Mlx5Provider() {
+  Mlx5Provider() {
     if (wrap_ibv_symbols() != 1) {
       PS_LOG(WARNING) << "Load mlx5 symbols fails.";
     }

src/rdma_transport.h

@@ -151,10 +151,10 @@ struct Endpoint {
 
   void SetNodeID(int id) { node_id = id; }
 
-  void InitWRContextHelper(struct ibv_pd *pd, WRContext *ctx,
-                             size_t num, WRContextType type,
-                             struct ibv_mr **mr, unsigned int access,
-                             ThreadsafeQueue<WRContext *> *queue = nullptr) {
+  void InitWRContextHelper(struct ibv_pd *pd, WRContext *ctx, size_t num,
+                           WRContextType type, struct ibv_mr **mr,
+                           unsigned int access,
+                           ThreadsafeQueue<WRContext *> *queue = nullptr) {
     char *buf;
     aligned_malloc(reinterpret_cast<void **>(&buf), kMempoolChunkSize * num);
     PS_CHECK(buf);
@@ -172,7 +172,8 @@ struct Endpoint {
     }
   }
 
-  void Init(struct ibv_cq *cq, struct ibv_pd *pd, RDMAProvider *provider, rdma_cm_id *id = nullptr) {
+  void Init(struct ibv_cq *cq, struct ibv_pd *pd, RDMAProvider *provider,
+            rdma_cm_id *id = nullptr) {
     struct ibv_qp_init_attr attr;
     memset(&attr, 0, sizeof(ibv_qp_init_attr));
     attr.send_cq = cq;
@@ -190,7 +191,8 @@ struct Endpoint {
     kMaxInlineSize = attr.cap.max_inline_data;
 
     PS_LOG(TRACE) << "qp created: pd=" << pd << " , cq=" << cq
-                  << ", qp=" << id->qp->qp_num << ", maxInline=" << kMaxInlineSize;
+                  << ", qp=" << id->qp->qp_num
+                  << ", maxInline=" << kMaxInlineSize;
     if (inited == 0) {
       rdma_provider = provider;
       InitWRContextHelper(pd, start_ctx, kStartDepth, kRendezvousStartContext,
@@ -383,8 +385,7 @@ class RDMATransport : public Transport {
     WRContext *context = nullptr;
     endpoint_->free_start_ctx.WaitAndPop(&context);
 
-    RendezvousStart *req =
-        reinterpret_cast<RendezvousStart *>(context->buffer);
+    RendezvousStart *req = reinterpret_cast<RendezvousStart *>(context->buffer);
     req->meta_len = msg_buf->inline_len;
     req->origin_addr = reinterpret_cast<uint64_t>(msg_buf);
     req->data_num = msg_buf->data.size();
@@ -463,8 +464,7 @@ class RDMATransport : public Transport {
 
       WRContext *reply_ctx_ptr = nullptr;
       endpoint_->free_reply_ctx.WaitAndPop(&reply_ctx_ptr);
-      auto *resp =
-          reinterpret_cast<RendezvousReply *>(reply_ctx_ptr->buffer);
+      auto *resp = reinterpret_cast<RendezvousReply *>(reply_ctx_ptr->buffer);
 
       // Populate reply with addresses and rkeys for both buffers
       resp->meta_addr = reinterpret_cast<uint64_t>(buf_ctx->meta_buffer);

src/rdma_van.h

@@ -782,14 +782,15 @@ class RDMAVan : public Van {
             continue;
           }
           PS_LOG(FATAL) << "Failed status \n"
-                        << ibv_wc_status_str(wc[i].status) << " " << wc[i].status << " "
-                        << static_cast<uint64_t>(wc[i].wr_id) << " " << wc[i].vendor_err
-                        << " " << wc[i].opcode << " "
+                        << ibv_wc_status_str(wc[i].status) << " "
+                        << wc[i].status << " "
+                        << static_cast<uint64_t>(wc[i].wr_id) << " "
+                        << wc[i].vendor_err << " " << wc[i].opcode << " "
                         << (wc[i].opcode == IBV_WC_RECV ? "RECV" : "OTHER")
-                        << " postoffice ptr: " << reinterpret_cast<void *>(postoffice_);
+                        << " postoffice ptr: "
+                        << reinterpret_cast<void *>(postoffice_);
         }
 
-
         // IBV_WC_RDMA_WRITE use msg_buf as the wr_id
         // so there won't be context and endpoint for this op
         if (wc[i].opcode == IBV_WC_RDMA_WRITE) {