Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestJS option unexpected disables initializeFieldsAsUndefined option #1156

Open
shohoney opened this issue Jan 16, 2025 · 1 comment
Open

Comments

@shohoney
Copy link

shohoney commented Jan 16, 2025

I noticed that when NestJS is set to true, the field for initializeFieldsAsUndefined is forcefully set to false. Would it be okay for me to open a PR to allow options to override this behavior? Is there a specific reason that we're disabling this behavior for NestJS?

@stephenh
Copy link
Owner

stephenh commented Jan 19, 2025

Hi @shohoney ; I had to do a big of digging, but that option was added to solve this issue:

#492

Which is actually a Next.js issue with getServerSideProps.

I dunno, I don't remember if "NestJS users might be running in Next.js so enabled this for good measure" or "I just conflated NestJS and Next.js in my head" 🤔 :-D .

Either way, yep definitely fine with a PR that just removes that forced opt-in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants