LINT: Prepend role name to variables

Linting requires variables on roles to have the role name prepended to them

Author: khalford

chatops_deployment/ansible/roles/haproxy/tasks/certbot.yml

@@ -35,26 +35,26 @@
   become: true
   ansible.builtin.stat:
     path: /etc/haproxy/{{ domain }}.crt
-  register: certificate_file
+  register: haproxy_certificate_file
 
 - name: Generate the certificate for the first time
   become: true
   ansible.builtin.command: |
     certbot certonly --standalone --non-interactive --agree-tos --expand --domains \
     {{ domain }},chatops.{{ domain }},prometheus.{{ domain }},grafana.{{ domain }},alertmanager.{{ domain }},kibana.{{ domain }} \
     -m [email protected]
-  register: generate_cert
-  changed_when: generate_cert.rc == 0
-  when: not certificate_file.stat.exists
+  register: haproxy_generate_cert
+  changed_when: haproxy_generate_cert.rc == 0
+  when: not haproxy_certificate_file.stat.exists
 
 - name: Copy certificate for the first time
   become: true
   ansible.builtin.command: |
     cat /etc/letsencrypt/live/{{ domain }}/privkey.pem \
     /etc/letsencrypt/live/{{ domain }}/fullchain.pem > /etc/haproxy/{{ domain }}.crt
-  register: copy_cert
-  changed_when: copy_cert.rc == 0
-  when: not certificate_file.stat.exists
+  register: haproxy_copy_cert
+  changed_when: haproxy_copy_cert.rc != 0
+  when: not haproxy_certificate_file.stat.exists
 
 - name: Create a cron job for the renewal of certificates
   become: true
@@ -99,4 +99,4 @@
   ansible.builtin.systemd_service:
     state: restarted
     name: haproxy.service
-  when: copy_cert.rc == 0
+  when: haproxy_copy_cert.rc == 0

chatops_deployment/ansible/roles/haproxy/tasks/haproxy.yml

@@ -19,11 +19,11 @@
   become: true
   ansible.builtin.stat:
     path: /etc/haproxy/{{ domain }}.crt
-  register: certificate_file
+  register: haproxy_certificate_file
 
 - name: Make sure haproxy.service is running
   become: true
   ansible.builtin.systemd_service:
     state: restarted
     name: haproxy.service
-  when: certificate_file.stat.exists
+  when: haproxy_certificate_file.stat.exists

chatops_deployment/ansible/roles/ssh_known_hosts/tasks/main.yml

@@ -18,50 +18,50 @@
           send "{{ bastion_key_passphrase }}\r"
           expect eof
         EOF
-      register: _
-      changed_when: _.rc == 0
+      register: ssh_known_hosts_
+      changed_when: ssh_known_hosts_.rc != 0
 
 - name: Remove FIP known hosts
   ansible.builtin.command: 'ssh-keygen -R "{{ terraform_floating_ip }}"'
-  register: _
-  changed_when: _.rc == 0
+  register: ssh_known_hosts_
+  changed_when: ssh_known_hosts_.rc != 0
 
 - name: Remove private VM known host entries
   ansible.builtin.command: "ssh-keygen -R {{ item }}"
   loop: "{{ groups['private'] }}"
-  register: _
-  changed_when: _.rc == 0
+  register: ssh_known_hosts_
+  changed_when: ssh_known_hosts_.rc != 0
 
 - name: Add FIP fingerprint to known hosts
   ansible.builtin.command: 'ssh-keyscan "{{ terraform_floating_ip }}" >> ~/.ssh/known_hosts'
-  register: _
-  changed_when: _.rc == 0
+  register: ssh_known_hosts_
+  changed_when: ssh_known_hosts_.rc != 0
 
 - name: Get private VM fingerprints and retrieve to local host
   delegate_to: "{{ terraform_floating_ip }}"
   block:
     - name: Add private VM fingerprints to known hosts on LB
       ansible.builtin.command: 'ssh-keyscan "{{ item }}" >> ~/.ssh/known_hosts'
       loop: "{{ groups['private'] }}"
-      register: _
-      changed_when: _.rc == 0
+      register: ssh_known_hosts_
+      changed_when: ssh_known_hosts_.rc != 0
 
     - name: Retrieve known hosts from LB
       ansible.builtin.fetch:
         src: "~/.ssh/known_hosts"
         dest: "private_known_hosts.tmp"
         flat: true
-      register: _
-      changed_when: _.rc == 0
+      register: ssh_known_hosts_
+      changed_when: ssh_known_hosts_.rc != 0
 
 - name: Append fetched known hosts to localhost
   ansible.builtin.command: "cat private_known_hosts.tmp >> ~/.ssh/known_hosts"
-  register: _
-  changed_when: _.rc == 0
+  register: ssh_known_hosts_
+  changed_when: ssh_known_hosts_.rc != 0
 
 - name: Remove private_known_hosts.tmp
   ansible.builtin.file:
     path: "private_known_hosts.tmp"
     state: absent
-  register: _
-  changed_when: _.rc == 0
+  register: ssh_known_hosts_
+  changed_when: ssh_known_hosts_.rc != 0

chatops_deployment/ansible/roles/terraform/tasks/deploy.yml

@@ -4,29 +4,29 @@
     - name: Check clouds.yaml
       ansible.builtin.stat:
         path: "~/.config/openstack/clouds.yaml"
-      register: clouds_yaml_state
+      register: terraform_clouds_yaml_state
 
     - name: Fail if clouds.yaml does not exist
       ansible.builtin.fail:
         msg: "Could not find a clouds.yaml in ~/.config/openstack/clouds.yaml"
-      when: not clouds_yaml_state.stat.exists
+      when: not terraform_clouds_yaml_state.stat.exists
 
 - name: Check public and private keys
   block:
     # We can ignore this warning as this command doesn't change anything when it runs.
     - name: Check Bastion public key is valid # noqa: no-changed-when
       ansible.builtin.command: "ssh-keygen -l -f '../terraform/bastion-key.pub'"
       ignore_errors: true
-      register: public_key_state
+      register: terraform_public_key_state
 
     # We can ignore this warning as this command doesn't change anything when it runs.
     - name: Check Bastion private key is valid # noqa: no-changed-when
       ansible.builtin.command: "ssh-keygen -l -f '../ansible/bastion-key'"
       ignore_errors: true
-      register: private_key_state
+      register: terraform_private_key_state
 
     - name: Generate an SSH key pair and copy to directories
-      when: public_key_state.rc != 0 or private_key_state.rc != 0
+      when: terraform_public_key_state.rc != 0 or terraform_private_key_state.rc != 0
       block:
         - name: Generate key
           community.crypto.openssh_keypair: