From 26d0b67e4dbafea47f3892ab51ab5f3672b882e4 Mon Sep 17 00:00:00 2001 From: Gavin Burnell Date: Tue, 10 Feb 2026 13:13:48 +0000 Subject: [PATCH 1/2] Replace pass with ellipsis in abstract methods --- bad_path/checker.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bad_path/checker.py b/bad_path/checker.py index ed75d66..a133366 100644 --- a/bad_path/checker.py +++ b/bad_path/checker.py @@ -386,12 +386,12 @@ def __init__( @abstractmethod def _load_invalid_chars(self) -> None: """Load platform-specific invalid characters and reserved names.""" - pass + ... @abstractmethod def _load_and_check_paths(self) -> None: """Load system and user paths, then check the current path against them.""" - pass + ... def _is_dangerous(self) -> bool: """Check if the path is dangerous based on current settings. From 4dbdfec70de1c7c45ddb932fc496612cd389288d Mon Sep 17 00:00:00 2001 From: Gavin Burnell Date: Tue, 10 Feb 2026 13:15:46 +0000 Subject: [PATCH 2/2] Refine notes on multi-platform coverage tracking Updated notes on platform-specific code coverage tracking. --- CODE_REVIEW.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CODE_REVIEW.md b/CODE_REVIEW.md index 2bb98b4..a80c4e5 100644 --- a/CODE_REVIEW.md +++ b/CODE_REVIEW.md @@ -100,7 +100,8 @@ No high-priority issues found. - **Current**: 73% coverage (merged from all platforms via Coveralls and Codacy) - **Target**: 85%+ coverage - **Recommendation**: Add more unit tests for error handling code paths -- **Note**: Platform-specific code (Windows, Darwin) is now properly tracked via multi-platform coverage merging with Coveralls and Codacy +- **Note**: Platform-specific code (Windows, Darwin) is now properly tracked via multi-platform + coverage merging with Coveralls and Codacy --- @@ -145,7 +146,8 @@ No high-priority issues found. - `bad_path/platforms/darwin.py`: Coverage tracked on macOS CI - `bad_path/platforms/windows.py`: Coverage tracked on Windows CI -**Note**: With Coveralls and Codacy integration, platform-specific code coverage is now properly tracked and merged from all CI platforms (Linux, Windows, macOS). +**Note**: With Coveralls and Codacy integration, platform-specific code coverage is now properly +tracked and merged from all CI platforms (Linux, Windows, macOS). ### Missing Test Coverage