This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
Layout selector popover appears when revisiting page that has an unfilled layouts block #228
Labels
bug
Something isn't working
Describe the bug
If I return to a page that has an
ab-layout-selector-placeholder
block where a layout has not been selected, I see the layout selector popover as soon as the editor loads.I did not expect that popover to appear when re-visiting a page until I click “Layout Library”.
I would expect the popover to appear only when first adding a layout to a page, or when clicking the “Show Layouts” button for an existing layout placeholder where I dismissed the selection.
Not a big issue, but it can be disorientating to see the layout selector when visiting an old page that hasn't been edited for some time if it contains a layout placeholder where no selection was made.
To Reproduce
Steps to reproduce the behavior:
You will see the layout selector immediately when the editor loads.
Version
Device and browser information
Possible resolutions
modalOpen
to false instead of true by default if possible, then have the buttons alter that state.atomic-blocks/src/blocks/block-layout/components/layout/layout-modal.js
Line 27 in 517fc47
Or:
ab-layout-selector-placeholder
block when dismissing the layout selection modal, because it may not need to exist if I intended to add a layout but then chose not to.ab-layout-selector-placeholder
blocks when publishing/updating the page, because they represent a layout that was added but not chosen.The text was updated successfully, but these errors were encountered: