Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Layout selector popover appears when revisiting page that has an unfilled layouts block #228

Open
nickcernis opened this issue Sep 2, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@nickcernis
Copy link
Collaborator

Describe the bug
If I return to a page that has an ab-layout-selector-placeholder block where a layout has not been selected, I see the layout selector popover as soon as the editor loads.

I did not expect that popover to appear when re-visiting a page until I click “Layout Library”.

I would expect the popover to appear only when first adding a layout to a page, or when clicking the “Show Layouts” button for an existing layout placeholder where I dismissed the selection.

Not a big issue, but it can be disorientating to see the layout selector when visiting an old page that hasn't been edited for some time if it contains a layout placeholder where no selection was made.

To Reproduce
Steps to reproduce the behavior:

  1. Click “Layouts” to display the Layout Selector.
  2. Dismiss the layout selector.
  3. Publish/update the page.
  4. Refresh the editor.

You will see the layout selector immediately when the editor loads.

Version

  • 2.0.2, develop

Device and browser information

  • Chrome, macOS

Possible resolutions

  1. Set modalOpen to false instead of true by default if possible, then have the buttons alter that state.

Or:

  1. Consider removing the ab-layout-selector-placeholder block when dismissing the layout selection modal, because it may not need to exist if I intended to add a layout but then chose not to.
  2. Consider removing ab-layout-selector-placeholder blocks when publishing/updating the page, because they represent a layout that was added but not chosen.
@mindctrl mindctrl added the bug Something isn't working label Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants