chore: addressing some PR comments

benbellick · benbellick · commit fea592182e06 · 2025-11-26T12:10:00.000-06:00
diff --git a/core/src/main/java/io/substrait/expression/Expression.java b/core/src/main/java/io/substrait/expression/Expression.java
@@ -672,8 +672,6 @@ public <R, C extends VisitationContext, E extends Throwable> R accept(
    *   <li>As {@code Literal.Struct} - see {@link UserDefinedStructLiteral}
    * </ul>
    *
-   * @see UserDefinedAnyLiteral
-   * @see UserDefinedStructLiteral
    */
   interface UserDefinedLiteral extends Literal {
     String urn();
@@ -684,7 +682,7 @@ interface UserDefinedLiteral extends Literal {
   }
 
   /**
-   * User-defined literal with value encoded as {@code google.protobuf.Any}.
+   * User-defined literal with value encoded as {@link com.google.protobuf.Any}.
    *
    * <p>This encoding allows for arbitrary binary data to be stored in the literal value.
    */
@@ -723,7 +721,7 @@ public <R, C extends VisitationContext, E extends Throwable> R accept(
   }
 
   /**
-   * User-defined literal with value encoded as {@code Literal.Struct}.
+   * User-defined literal with value encoded as {@link io.substrait.proto.Expression.Literal.Struct}.
    *
    * <p>This encoding uses a structured list of fields to represent the literal value.
    */

Original file line number	Diff line number	Diff line change
`@@ -672,8 +672,6 @@ public <R, C extends VisitationContext, E extends Throwable> R accept(`
`672`	`672`	`* <li>As {@code Literal.Struct} - see {@link UserDefinedStructLiteral}`
`673`	`673`	`* </ul>`
`674`	`674`	`*`
`675`		`- * @see UserDefinedAnyLiteral`
`676`		`- * @see UserDefinedStructLiteral`
`677`	`675`	`*/`
`678`	`676`	`interface UserDefinedLiteral extends Literal {`
`679`	`677`	`String urn();`
`@@ -684,7 +682,7 @@ interface UserDefinedLiteral extends Literal {`
`684`	`682`	`}`
`685`	`683`
`686`	`684`	`/**`
`687`		`- * User-defined literal with value encoded as {@code google.protobuf.Any}.`
	`685`	`+ * User-defined literal with value encoded as {@link com.google.protobuf.Any}.`
`688`	`686`	`*`
`689`	`687`	`* <p>This encoding allows for arbitrary binary data to be stored in the literal value.`
`690`	`688`	`*/`
`@@ -723,7 +721,7 @@ public <R, C extends VisitationContext, E extends Throwable> R accept(`
`723`	`721`	`}`
`724`	`722`
`725`	`723`	`/**`
`726`		`- * User-defined literal with value encoded as {@code Literal.Struct}.`
	`724`	`+ * User-defined literal with value encoded as {@link io.substrait.proto.Expression.Literal.Struct}.`
`727`	`725`	`*`
`728`	`726`	`* <p>This encoding uses a structured list of fields to represent the literal value.`
`729`	`727`	`*/`