Skip to content

Feat: add non-nginx ingress support via X_FORWARDED_* header support for media-auth #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

centerionware
Copy link

Purpose

Description...
RE: #826

Proposal

Fallback to X_FORWARDED_* headers.

Copy link
Member

@lunika lunika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for your contribution.

Can you update the tests reflecting your modification (in core/tests/documents/test_api_documents_media_auth.py).

Also, we only accept signed commits and your commit syntax does not follow our contributing guide. Can you take a look at it please ? (see CONTRIBUTING.md)

Thanks

@Nastaliss
Copy link

@centerionware Thank you for your issue / pull request. I was able to make docs work with traefik.
I can tackle the tests if you do not currently have time !

@centerionware
Copy link
Author

centerionware commented Jul 3, 2025

@centerionware Thank you for your issue / pull request. I was able to make docs work with traefik. I can tackle the tests if you do not currently have time !

If you want to take it over please be my guest. I don't have the time myself. It's such a small change, only spent like an hour doing the background research and testing to make sure it works. would probably be a good idea to do the tests, actually sign the commits (something I'm just not used to and it's such a weird requirement), and add the middleware parts to documentation in tree. if I can somehow 'sign' the past commits i will if that would make things easier, but frankly if you just want to copy and paste the changes to a new tree i really couldn't care less. It's not like it's a fancy new algorithm that revolutionizes the flow of streamlining the process of other random silicon valley market jargon.

edit: *replied to the wrong thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants