feat: add ansible task testing infrastructure based on Docker and pytest #1882
Conversation
jfroche
force-pushed
the
test/ansible-tasks
branch
8 times, most recently
from
a79867e to
7fad1eb
Compare
hunleyd
left a comment
hunleyd
left a comment
There was a problem hiding this comment.
mostly ansible-lint fixups
jfroche
force-pushed
the
test/ansible-tasks
branch
from
7fad1eb to
dc23e8f
Compare
| ansible.builtin.user: | ||
| name: 'nginx' | ||
| state: 'present' | ||
| name: nginx |
There was a problem hiding this comment.
quote dropping is intentional?
There was a problem hiding this comment.
probably not is my guess. maybe needs rebase
There was a problem hiding this comment.
I ran ansible-lint --fix and it automatically removes unnecessary quotes to follow YAML best practices for improved readability (https://docs.ansible.com/projects/lint/rules/yaml/#yaml).
|
@hunleyd I realize it may not yet be documented very well, but in order for you to get 1:1 parity with the linter in this PR, you would want to:
By doing it this way, you'll then use the same ansible lint version in this PR, and the same configuration. This helps avoid the "works on my machine" problem that may come up if we install ansible lint and tools from brew install etc. We can get 1:1 with what other developers are doing with |
This complements the existing AMI tests in testinfra by providing a faster feedback loops for Ansible development without requiring a full VM. We are also using testinfra to validate that the Ansible tasks have the desired effect. It is based on Docker, it can be run locally (e.g. macOS) or in CI. Note that this approach is not intended to replace the AMI tests, but rather to provide a more efficient way to test Ansible tasks during development. You can run the tests using `nix run -L .\#ansible-test`
Configure pre-commit hook to run ansible-lint on test playbooks and their dependencies. Since test playbooks include tasks from existing task files, ansible-lint automatically validates those dependencies as well.
jfroche
force-pushed
the
test/ansible-tasks
branch
from
dc23e8f to
bac839f
Compare
|
Also we have pre-commit hook in the dev shell. So if you start the dev shell using The pre-commit hook configuration is defined in |
This complements the existing AMI tests in testinfra by providing a faster feedback loops for Ansible development without requiring a full VM.
We are also using testinfra to validate that the Ansible tasks have the desired effect.
It is based on Docker, it can be run locally (e.g. macOS) or in CI.
Note that this approach is not intended to replace the AMI tests, but rather to provide a more efficient way to test Ansible tasks during development.
You can run the tests using
nix run -L .\#ansible-test