test(functions): resolve flaky test failures from Docker exec cleanup race condition (#1819)

Author: mandarini

packages/core/functions-js/test/relay/container.ts

@@ -27,6 +27,22 @@ export class Relay {
     this.execCache = execCache
     this.execRun = execRun
   }
+
+  /**
+   * Safely stops the relay container and cleans up exec processes
+   */
+  async stop(): Promise<void> {
+    try {
+      // Try to stop the container - this will trigger cleanup of exec instances
+      await this.container.stop({ timeout: 5000 })
+    } catch (error: any) {
+      // Ignore "no such exec" errors during cleanup - they're harmless
+      if (!error?.message?.includes('no such exec')) {
+        throw error
+      }
+      // Container is already stopped or exec instances are gone, which is fine
+    }
+  }
 }
 
 /**
@@ -100,7 +116,7 @@ export async function runRelay(
         log(`function started to serve: ${slug + '-' + id}`)
         // Add a small delay after health check passes to ensure full readiness
         await new Promise((resolve) => setTimeout(resolve, 1000))
-        return { container: startedRelay, id, execCache, execRun }
+        return new Relay(startedRelay, id, execCache, execRun)
       }
     } catch {
       /* we actually don't care about errors here */

packages/core/functions-js/test/spec/hello.spec.ts

@@ -18,7 +18,9 @@ describe('basic tests (hello function)', () => {
   })
 
   afterAll(async () => {
-    relay && relay.container && (await relay.container.stop())
+    if (relay) {
+      await relay.stop()
+    }
   })
 
   test('invoke hello with auth header', async () => {

packages/core/functions-js/test/spec/hijack.spec.ts

@@ -18,7 +18,9 @@ describe('hijack connection', () => {
   })
 
   afterAll(async () => {
-    relay && relay.container && (await relay.container.stop())
+    if (relay) {
+      await relay.stop()
+    }
   })
 
   test('invoke func', async () => {

packages/core/functions-js/test/spec/params.spec.ts

@@ -22,7 +22,9 @@ describe('params reached to function', () => {
   })
 
   afterAll(async () => {
-    relay && relay.container && (await relay.container.stop())
+    if (relay) {
+      await relay.stop()
+    }
   })
 
   test('invoke mirror', async () => {