Method -thresh2 has arg named 'function', but doc has 'argument:: thresh'.

[joslloand]

WARNING: SCDoc: In /Applications/SuperCollider 3.13.0/SuperCollider.app/Contents/Resources/HelpSource/Classes/UGen.schelp
  Method -thresh2 has arg named 'function', but doc has 'argument:: thresh'.

This is a result of importing -thresh2 from SimpleNumber.

Relevant code for SimpleNumber:

• https://github.com/supercollider-quarks/MathLib/blob/master/HelpSource/Classes/SimpleNumber.ext.schelp#L11-L19
• https://github.com/supercollider-quarks/MathLib/blob/master/classes/SystemOverwrites/extSimpleNumber.sc#L4

... and UGen:

• https://github.com/supercollider-quarks/MathLib/blob/master/HelpSource/Classes/UGen.ext.schelp#L5C1-L5C35
• https://github.com/supercollider-quarks/MathLib/blob/master/classes/SystemOverwrites/extUGen.sc#L2

---

Suggested fix:

Update UGen.ext.schelp. Reference SimpleNumber:-thresh2, but refactor to use correct args. E.g., first arg should be named function rather than thresh.

[joslloand]

@mtmccrea, do you recall why the first argument was listed as function rather than thresh?

@prko has made a PR which updates the arg to thresh, which isn't quite what I was suggesting above. (I suggested updating the schelp rather than the sc file.)

I have a feeling that there could possibly be a keyword call in atk-sc3 that uses the current arg form, i.e., function. So I think there would be a risk in accepting @prko's change without looking deeper in atk-sc3.

Any thoughts @mtmccrea?