- avoid unused-value compiler warnings

- added global header

- fix cmake config

Author: svdev

.gitignore

@@ -13,4 +13,5 @@ _deps
 lib/*.a
 bin/
 patterns.cbp
+patterns*.cmake
 test/gtest

CMakeLists.txt

@@ -1,19 +1,59 @@
-cmake_minimum_required(VERSION 3.9)
-project(patterns)
-set(CMAKE_ROOT_)
+cmake_minimum_required(VERSION 3.12.4)
+project("patterns"
+        VERSION 0.1.0
+        DESCRIPTION "A header only c++17 library with GoF design patterns"
+        HOMEPAGE_URL "https://github.com/svdev/design-patterns-cpp17"
+        LANGUAGES CXX)
 
 set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_EXTENSIONS OFF)
 set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")
 set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")
 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")
 
+if(NOT CMAKE_BUILD_TYPE)
+    set(CMAKE_BUILD_TYPE "Release" FORCE)
+endif(NOT CMAKE_BUILD_TYPE)
+
+add_library(${PROJECT_NAME} INTERFACE)
+target_compile_features(${PROJECT_NAME} INTERFACE cxx_std_17)
+target_include_directories(${PROJECT_NAME} INTERFACE
+        $<BUILD_INTERFACE:${${PROJECT_NAME}_SOURCE_DIR}/include>
+        $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)
+
+set(CMAKE_ROOT)
+install(TARGETS ${PROJECT_NAME}
+        EXPORT ${PROJECT_NAME}_Targets
+        ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
+        LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
+        RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
+
+include(CMakePackageConfigHelpers)
+write_basic_package_version_file("${PROJECT_NAME}ConfigVersion.cmake"
+        VERSION ${PROJECT_VERSION}
+        COMPATIBILITY SameMajorVersion)
+
+install(EXPORT ${PROJECT_NAME}_Targets
+        FILE ${PROJECT_NAME}Targets.cmake
+        NAMESPACE ${PROJECT_NAME}::
+        DESTINATION ${CMAKE_ROOT}/Modules/${PROJECT_NAME})
+
+install(FILES "${PROJECT_BINARY_DIR}/${PROJECT_NAME}ConfigVersion.cmake"
+        "${PROJECT_BINARY_DIR}/${PROJECT_NAME}Config.cmake"
+        DESTINATION ${CMAKE_ROOT}/Modules/${PROJECT_NAME})
+
+file(GLOB PATTERN_HEADERS
+        ${PROJECT_SOURCE_DIR}/include/**/*.hpp
+        ${PROJECT_SOURCE_DIR}/include/*.hpp)
+
+foreach(FILE ${PATTERN_HEADERS})
+    get_filename_component(DIR ${FILE} DIRECTORY)
+    file(RELATIVE_PATH REL ${PROJECT_SOURCE_DIR}/include ${DIR})
+    install(FILES ${FILE} DESTINATION include/${PROJECT_NAME}/${REL})
+endforeach()
+
 include_directories(include)
 
-add_subdirectory(lib/googletest)
+# EXCLUDE_FROM_ALL disables install targets for googletest subdirectory.
+add_subdirectory(lib/googletest EXCLUDE_FROM_ALL)
 add_subdirectory(test)
-
-option(USE_CLANG "Build using Clang++" ON)
-if (USE_CLANG)
-    set(CMAKE_CXX_COMPILER clang++)
-endif(USE_CLANG)

README.md

@@ -7,15 +7,28 @@ Design Patterns Headers-only Library for C++17
 
     git clone --recurse-submodules http://github.com/svdev/design-patterns-cpp17
     cd design-patterns-cpp17
-    cmake -G "Unix Makefiles" .
-    make
-    
-    
+    cmake -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -G "Unix Makefiles" .
+    make -j8    
+
 ## Test
 
     make check
 
 
+## Install
+
+    sudo make install    
+    
+## Usage
+
+    project("my-project")
+    
+    find_package(patterns CONFIG REQUIRED)
+    
+    add_executable(${PROJECT_NAME} src/main.cc)
+    target_link_libraries(${PROJECT_NAME} patterns::patterns)
+
+    
 ## Author
 
     svdev - http://github.com/svdev

include/creational/singleton.hpp

@@ -40,7 +40,7 @@ class singleton {
          */
         // std::cout << "singleton Constructor" << std::endl;
         static bool static_init = []() -> bool {
-          singleton_container<T>::instance;
+          (void)singleton_container<T>::instance;
           // std::cout << "singleton Initialized" << std::endl;
           return true;
         }();

include/patterns.hpp

@@ -0,0 +1,11 @@
+#ifndef DESIGN_PATTERNS_HPP
+#define DESIGN_PATTERNS_HPP
+
+#include "behavioral/observer.hpp"
+#include "behavioral/visitor.hpp"
+
+#include "creational/singleton.hpp"
+#include "creational/factory.hpp"
+
+
+#endif //DESIGN_PATTERNS_HPP