Skip to content

ClientContext should be a type, not String #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ktoso opened this issue Sep 17, 2020 · 1 comment
Open

ClientContext should be a type, not String #169

ktoso opened this issue Sep 17, 2020 · 1 comment
Labels
kind/enhancement Improvements to existing feature.

Comments

@ktoso
Copy link
Contributor

ktoso commented Sep 17, 2020 •
edited
Loading

Expected behavior

The ClientContext is often of well known shape:

It should handle the typing more gracefully I think, see docs:
https://docs.aws.amazon.com/lambda/latest/dg/nodejs-context.html

See also: #167 (comment) for discussion on this

Actual behavior

It's a String today:

            let clientContext: String?
@sebsto sebsto added the kind/enhancement Improvements to existing feature. label May 29, 2024
@sebsto
Copy link
Contributor

sebsto commented Nov 7, 2024

Still valid for v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktoso @sebsto