Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please bump libc to 0.2.170 #2387

Closed
0-wiz-0 opened this issue Feb 23, 2025 · 5 comments · Fixed by #2388
Closed

please bump libc to 0.2.170 #2387

0-wiz-0 opened this issue Feb 23, 2025 · 5 comments · Fixed by #2388
Labels
feature New feature request needs info

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Feb 23, 2025

This is a follow-up to #2329

There was a bug in the NetBSD implementation for getmntinfo in the libc crate which has been fixed and a new version of libc is released. This bug broke deleting files on file systems except /, since trash-rs didn't properly recognize that it was not on the same file system, and trashing to a different file system is not supported.

Please run cargo upgrade so libc 0.2.170 is pulled in.

Thank you!

@0-wiz-0 0-wiz-0 added the feature New feature request label Feb 23, 2025
Copy link

Hey @0-wiz-0, I noticed that you did not correctly follow the issue template. Please ensure that:

  • The requested feature does not exist in the newest nightly build.
  • The debug information (yazi --debug) is updated for the newest nightly.
  • All required fields in the checklist have been checked.

Issues with needs info will be marked ready once edited with the proper content, or closed after 2 days of inactivity.

@0-wiz-0
Copy link
Author

0-wiz-0 commented Feb 23, 2025

I checked and Cargo.lock currently requires 0.2.169

@sxyazi
Copy link
Owner

sxyazi commented Feb 23, 2025

Thank you for your follow-up update @0-wiz-0!

I've updated libc and trash to the latest in #2388

@0-wiz-0
Copy link
Author

0-wiz-0 commented Feb 23, 2025

Thank you for fixing this so quickly!

Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please file a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request needs info
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants