- padded account state voting key (#743)

- change log updates

Author: rg911

CHANGELOG.md

@@ -4,26 +4,15 @@ All notable changes to this project will be documented in this file.
 
 The changelog format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
-## [0.22.1] - 10-Dec-2020
+## [0.22.2] - 12-Dec-2020
 
 **Milestone**: Catapult-server finality(0.10.0.4)
  Package  | Version  | Link
 ---|---|---
-SDK Core| v0.22.1 | [symbol-sdk](https://www.npmjs.com/package/symbol-sdk)
-Catbuffer | v0.0.24 | [catbuffer-typescript](https://www.npmjs.com/package/catbuffer-typescript)
+SDK Core| v0.22.2 | [symbol-sdk](https://www.npmjs.com/package/symbol-sdk)
+Catbuffer | v0.0.25 | [catbuffer-typescript](https://www.npmjs.com/package/catbuffer-typescript)
 Client Library | v0.10.5-1  | [symbol-openapi-typescript-fetch-client](https://www.npmjs.com/package/symbol-openapi-typescript-fetch-client)
 
-- Fixed finalization proof schema version compatibility issue.
-
-## [0.22.0] - 8-Dec-2020
-
-**Milestone**: Catapult-server finality(0.10.0.4)
- Package  | Version  | Link
----|---|---
-SDK Core| v0.22.0 | [symbol-sdk](https://www.npmjs.com/package/symbol-sdk)
-Catbuffer | v0.0.24 | [catbuffer-typescript](https://www.npmjs.com/package/catbuffer-typescript)
-Client Library | v0.10.4  | [symbol-openapi-typescript-fetch-client](https://www.npmjs.com/package/symbol-openapi-typescript-fetch-client)
-
 - **[BREAKING CHANGE]** `Deadline.create` requires the configurable `epochAdjustment` from the network properties. The value can be retrieved using ``RepositoryFactory.getEpochAdjustment()`` or calling catapult-rest's `network/properties` endpoint.
 - **[BREAKING CHANGE]** `NetworkCurrency` subclasses replaced with `Currency` objects. You can retrieve the network currencies with ``RepositoryFactory.getCurrencies()``.
 - **[BREAKING CHANGE]** `SecretLockRepository.getSecretLock` has been updated. It now takes the composite hash as parameter.
@@ -41,6 +30,7 @@ Client Library | v0.10.4  | [symbol-openapi-typescript-fetch-client](https://www
 - `Listener` now accepts address aliases as `UnresolvedAddress` objects.
 - Added V1 and V2 Voting Key transaction support.
 - Updated `FinalizationProof` object with the new ``SignatureSchema`` for catapult-server tree testnet/v3.
+- Fixed finalization proof schema version compatibility issue.
 
 ## [0.21.0] - 25-Sep-2020
 

package-lock.json

@@ -99,7 +99,7 @@
     "dependencies": {
         "@js-joda/core": "^3.2.0",
         "bluebird": "^3.7.2",
-        "catbuffer-typescript": "0.0.24",
+        "catbuffer-typescript": "0.0.25",
         "crypto-js": "^4.0.0",
         "diff": "^4.0.2",
         "futoin-hkdf": "^1.3.2",

package.json

@@ -32,6 +32,7 @@ import {
     PinnedVotingKeyBuilder,
     VotingKeyDto,
 } from 'catbuffer-typescript';
+import { VotingKeyPaddingDto } from 'catbuffer-typescript/dist/VotingKeyPaddingDto';
 import { Convert } from '../../core/format';
 import { Mosaic, MosaicId } from '../mosaic';
 import { UInt64 } from '../UInt64';
@@ -179,10 +180,10 @@ export class AccountInfo {
     }
 
     private static toPinnedVotingKeyBuilder(key: AccountLinkVotingKey): PinnedVotingKeyBuilder {
-        const votingKeyDto = new VotingKeyDto(Convert.hexToUint8(key.publicKey));
+        const votingKeyDto = new VotingKeyDto(Convert.hexToUint8(key.publicKey).slice(0, 32));
         const startEpoch: FinalizationEpochDto = new FinalizationEpochDto(key.startEpoch);
         const endEpoch: FinalizationEpochDto = new FinalizationEpochDto(key.endEpoch);
-        return new PinnedVotingKeyBuilder(votingKeyDto, startEpoch, endEpoch);
+        return new PinnedVotingKeyBuilder(votingKeyDto, new VotingKeyPaddingDto(new Uint8Array(16)), startEpoch, endEpoch);
     }
 
     private static toMosaicBuilder(m: Mosaic): MosaicBuilder {

src/model/account/AccountInfo.ts

@@ -102,7 +102,6 @@ export class VotingKeyLinkV1Transaction extends Transaction {
         transactionInfo?: TransactionInfo,
     ) {
         super(TransactionType.VOTING_KEY_LINK, networkType, version, deadline, maxFee, signature, signer, transactionInfo);
-        Convert.validateHexString(linkedPublicKey, 96, 'Invalid linkedPublicKey');
     }
 
     /**

src/model/transaction/VotingKeyLinkV1Transaction.ts

@@ -115,7 +115,15 @@ describe('AccountInfo', () => {
 
         const serialized = accountInfo.serialize();
         expect(Convert.uint8ToHex(serialized)).eq(
-            '01007826D27E1D0A26CA4E316F901E23E55C8711DB20DF5C49B501000000000000002E834140FD66CF87B254A693A2C7862C819217B676D3943267156625E816EC6F0D00000000000000000107012E834140FD66CF87B254A693A2C7862C819217B676D3943267156625E816EC6F2E834140FD66CF87B254A693A2C7862C819217B676D3943267156625E816EC6F2E834140FD66CF87B254A693A2C7862C819217B676D3943267156625E816EC6F3E834140FD66CF87B254A693A2C7862C819217B676D3943267156625E816EC6F0100000003000000B2C62D18000000003E19000000000000E8030000000000006400000000000000010000000A00000000000000D007000000000000C800000000000000020000001400000000000000B80B0000000000002C01000000000000030000001E00000000000000A00F00000000000090010000000000000400000028000000000000008813000000000000F401000000000000050000003200000000000000010029CF5FD941AD25D5BA9F1C6DB3700100',
+            '01007826D27E1D0A26CA4E316F901E23E55C8711DB20DF5C49B501000000000000002E834140FD66CF87B254A693A' +
+                '2C7862C819217B676D3943267156625E816EC6F0D00000000000000000107012E834140FD66CF87B254A693A2C786' +
+                '2C819217B676D3943267156625E816EC6F2E834140FD66CF87B254A693A2C7862C819217B676D3943267156625E81' +
+                '6EC6F2E834140FD66CF87B254A693A2C7862C819217B676D3943267156625E816EC6F3E834140FD66CF87B254A693' +
+                'A2C7862C819217B676D3943267156625E816EC6F000000000000000000000000000000000100000003000000B2C62' +
+                'D18000000003E19000000000000E8030000000000006400000000000000010000000A00000000000000D007000000' +
+                '000000C800000000000000020000001400000000000000B80B0000000000002C01000000000000030000001E00000' +
+                '000000000A00F00000000000090010000000000000400000028000000000000008813000000000000F40100000000' +
+                '0000050000003200000000000000010029CF5FD941AD25D5BA9F1C6DB3700100',
         );
         deepEqual(AccountStateBuilder.loadFromBinary(serialized).serialize(), serialized);
     });