Allow usage without twig (#461)

* allow usage of route defaults validator without twig

Author: alekitto

composer.json

@@ -17,8 +17,7 @@
     "require": {
         "php": "^7.2 || ^8.0",
         "symfony-cmf/routing": "^2.3.0",
-        "symfony/framework-bundle": "^4.4 || ^5.0",
-        "twig/twig": "^2.4.4 || ^3.0"
+        "symfony/framework-bundle": "^4.4 || ^5.0"
     },
     "require-dev": {
         "jackalope/jackalope-doctrine-dbal": "^1.3",
@@ -37,7 +36,8 @@
         "symfony/twig-bundle": "^4.4 || ^5.0",
         "symfony/monolog-bundle": "^3.5",
         "doctrine/phpcr-bundle": "^2.1",
-        "symfony/serializer": "^4.4 || ^5.0"
+        "symfony/serializer": "^4.4 || ^5.0",
+        "twig/twig": "^2.4.4 || ^3.0"
     },
     "suggest": {
         "doctrine/phpcr-odm": "To enable support for the PHPCR ODM documents (^1.4)",

src/Resources/config/validators.xml

@@ -10,7 +10,7 @@
                 class="Symfony\Cmf\Bundle\RoutingBundle\Validator\Constraints\RouteDefaultsTwigValidator"
         >
             <argument id="controller_resolver" type="service"/>
-            <argument id="twig.loader" type="service"/>
+            <argument id="twig.loader" type="service" on-invalid="null"/>
             <tag name="validator.constraint_validator" alias="cmf_routing.validator.route_defaults" />
         </service>
     </services>

src/Validator/Constraints/RouteDefaultsTwigValidator.php

@@ -25,11 +25,11 @@ class RouteDefaultsTwigValidator extends ConstraintValidator
     private $controllerResolver;
 
     /**
-     * @var LoaderInterface
+     * @var LoaderInterface|null
      */
     private $twig;
 
-    public function __construct(ControllerResolverInterface $controllerResolver, LoaderInterface $twig)
+    public function __construct(ControllerResolverInterface $controllerResolver, ?LoaderInterface $twig)
     {
         $this->controllerResolver = $controllerResolver;
         $this->twig = $twig;
@@ -49,7 +49,7 @@ public function validate($defaults, Constraint $constraint)
             }
         }
 
-        if (isset($defaults['_template']) && null !== $defaults['_template']) {
+        if (null !== $this->twig && isset($defaults['_template']) && null !== $defaults['_template']) {
             $template = $defaults['_template'];
 
             if (false === $this->twig->exists($template)) {

tests/Unit/Validator/Constraints/RouteDefaultsTwigValidatorTest.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Cmf\Bundle\RoutingBundle\Tests\Unit\Validator\Constraints;
 
+use Symfony\Cmf\Bundle\RoutingBundle\Validator\Constraints\RouteDefaults;
 use Symfony\Cmf\Bundle\RoutingBundle\Validator\Constraints\RouteDefaultsTwigValidator;
 use Twig\Loader\LoaderInterface;
 
@@ -25,4 +26,15 @@ protected function createValidator()
     {
         return new RouteDefaultsTwigValidator($this->controllerResolver, $this->engine);
     }
+
+    public function testNoTemplateViolationWithoutTwig()
+    {
+        $this->validator = new RouteDefaultsTwigValidator($this->controllerResolver, null);
+        $this->validator->validate(
+            ['_template' => 'NotExistingBundle:Foo:bar.html.twig'],
+            new RouteDefaults(['message' => 'my message'])
+        );
+
+        $this->assertNoViolation();
+    }
 }