Fix MultiAgent container compilation by using inline Handoff definitions

The container compiler was incorrectly inlining Handoff service references,
causing empty arrays to be passed instead of proper references. Fixed by
using inline Definition objects for handoffs instead of registering them
as separate services.

This resolves the container lint error: "argument 3 of MultiAgent::__construct()
accepts AgentInterface, array passed"

- Reverted to inline Handoff Definition objects
- Updated tests to expect Definition objects instead of References
- Fixed test assertions for exception messages with quotes

Author: OskarStark

src/ai-bundle/src/AiBundle.php

@@ -1204,16 +1204,12 @@ private function processMultiAgentConfig(string $name, array $config, ContainerB
         $handoffReferences = [];
 
         foreach ($config['handoffs'] as $agentName => $whenConditions) {
-            // Register each handoff as a service
-            $handoffId = 'ai.multi_agent.'.$name.'.handoff.'.$agentName;
-            $handoffDefinition = new Definition(Handoff::class, [
+            // Create handoff definitions directly (not as separate services)
+            // The container will inline simple value objects like Handoff
+            $handoffReferences[] = new Definition(Handoff::class, [
                 new Reference(self::normalizeAgentServiceId($agentName)),
                 $whenConditions,
             ]);
-            $container->setDefinition($handoffId, $handoffDefinition);
-
-            // Reference the handoff service
-            $handoffReferences[] = new Reference($handoffId);
         }
 
         $multiAgentId = 'ai.multi_agent.'.$name;

src/ai-bundle/tests/DependencyInjection/AiBundleTest.php

@@ -2127,20 +2127,16 @@ public function testValidMultiAgentConfiguration()
         $this->assertInstanceOf(Reference::class, $arguments[0]);
         $this->assertSame('ai.agent.dispatcher', (string) $arguments[0]);
 
-        // Second argument: handoffs array (now references to handoff services)
+        // Second argument: handoffs array
         $handoffs = $arguments[1];
         $this->assertIsArray($handoffs);
         $this->assertCount(1, $handoffs);
 
-        // Verify handoff reference
-        $handoffRef = $handoffs[0];
-        $this->assertInstanceOf(Reference::class, $handoffRef);
-        $this->assertSame('ai.multi_agent.support.handoff.technical', (string) $handoffRef);
-
-        // Check the actual handoff service definition
-        $handoffDef = $container->getDefinition('ai.multi_agent.support.handoff.technical');
-        $this->assertSame(Handoff::class, $handoffDef->getClass());
-        $handoffArgs = $handoffDef->getArguments();
+        // Verify handoff structure
+        $handoff = $handoffs[0];
+        $this->assertInstanceOf(Definition::class, $handoff);
+        $this->assertSame(Handoff::class, $handoff->getClass());
+        $handoffArgs = $handoff->getArguments();
         $this->assertCount(2, $handoffArgs);
         $this->assertInstanceOf(Reference::class, $handoffArgs[0]);
         $this->assertSame('ai.agent.technical', (string) $handoffArgs[0]);
@@ -2201,26 +2197,25 @@ public function testMultiAgentWithMultipleHandoffs()
         $this->assertIsArray($handoffs);
         $this->assertCount(2, $handoffs);
 
-        // Both handoffs should be References to handoff services
+        // Both handoffs should be Definition objects
         foreach ($handoffs as $handoff) {
-            $this->assertInstanceOf(Reference::class, $handoff);
+            $this->assertInstanceOf(Definition::class, $handoff);
+            $this->assertSame(Handoff::class, $handoff->getClass());
+            $handoffArgs = $handoff->getArguments();
+            $this->assertCount(2, $handoffArgs);
+            $this->assertInstanceOf(Reference::class, $handoffArgs[0]);
+            $this->assertIsArray($handoffArgs[1]);
         }
 
-        // Verify first handoff service (code_expert)
-        $codeHandoffRef = $handoffs[0];
-        $this->assertSame('ai.multi_agent.customer_service.handoff.code_expert', (string) $codeHandoffRef);
-        $codeHandoffDef = $container->getDefinition('ai.multi_agent.customer_service.handoff.code_expert');
-        $this->assertSame(Handoff::class, $codeHandoffDef->getClass());
-        $codeHandoffArgs = $codeHandoffDef->getArguments();
+        // Verify first handoff (code_expert)
+        $codeHandoff = $handoffs[0];
+        $codeHandoffArgs = $codeHandoff->getArguments();
         $this->assertSame('ai.agent.code_expert', (string) $codeHandoffArgs[0]);
         $this->assertSame(['bug', 'code', 'programming', 'technical'], $codeHandoffArgs[1]);
 
-        // Verify second handoff service (billing_expert)
-        $billingHandoffRef = $handoffs[1];
-        $this->assertSame('ai.multi_agent.customer_service.handoff.billing_expert', (string) $billingHandoffRef);
-        $billingHandoffDef = $container->getDefinition('ai.multi_agent.customer_service.handoff.billing_expert');
-        $this->assertSame(Handoff::class, $billingHandoffDef->getClass());
-        $billingHandoffArgs = $billingHandoffDef->getArguments();
+        // Verify second handoff (billing_expert)
+        $billingHandoff = $handoffs[1];
+        $billingHandoffArgs = $billingHandoff->getArguments();
         $this->assertSame('ai.agent.billing_expert', (string) $billingHandoffArgs[0]);
         $this->assertSame(['payment', 'invoice', 'subscription', 'refund'], $billingHandoffArgs[1]);
     }
@@ -2310,7 +2305,7 @@ public function testMultiAgentReferenceToNonExistingAgentThrowsException()
     public function testAgentAndMultiAgentNameConflictThrowsException()
     {
         $this->expectException(InvalidConfigurationException::class);
-        $this->expectExceptionMessage('Agent names and multi-agent names must be unique. Duplicate name(s) found: support');
+        $this->expectExceptionMessage('Agent names and multi-agent names must be unique. Duplicate name(s) found: "support"');
 
         $this->buildContainer([
             'ai' => [
@@ -2335,7 +2330,7 @@ public function testAgentAndMultiAgentNameConflictThrowsException()
     public function testMultipleAgentAndMultiAgentNameConflictsThrowsException()
     {
         $this->expectException(InvalidConfigurationException::class);
-        $this->expectExceptionMessage('Agent names and multi-agent names must be unique. Duplicate name(s) found: support, billing');
+        $this->expectExceptionMessage('Agent names and multi-agent names must be unique. Duplicate name(s) found: "support, billing"');
 
         $this->buildContainer([
             'ai' => [
@@ -2466,21 +2461,17 @@ public function testComprehensiveMultiAgentHappyPath()
         $this->assertIsArray($csHandoffs);
         $this->assertCount(2, $csHandoffs);
 
-        // Code expert handoff reference
-        $codeHandoffRef = $csHandoffs[0];
-        $this->assertInstanceOf(Reference::class, $codeHandoffRef);
-        $this->assertSame('ai.multi_agent.customer_support.handoff.code_expert', (string) $codeHandoffRef);
-        $codeHandoffDef = $container->getDefinition('ai.multi_agent.customer_support.handoff.code_expert');
-        $codeHandoffArgs = $codeHandoffDef->getArguments();
+        // Code expert handoff
+        $codeHandoff = $csHandoffs[0];
+        $this->assertInstanceOf(Definition::class, $codeHandoff);
+        $codeHandoffArgs = $codeHandoff->getArguments();
         $this->assertSame('ai.agent.code_expert', (string) $codeHandoffArgs[0]);
         $this->assertSame(['bug', 'error', 'code', 'debug', 'performance', 'optimization'], $codeHandoffArgs[1]);
 
-        // Docs expert handoff reference
-        $docsHandoffRef = $csHandoffs[1];
-        $this->assertInstanceOf(Reference::class, $docsHandoffRef);
-        $this->assertSame('ai.multi_agent.customer_support.handoff.docs_expert', (string) $docsHandoffRef);
-        $docsHandoffDef = $container->getDefinition('ai.multi_agent.customer_support.handoff.docs_expert');
-        $docsHandoffArgs = $docsHandoffDef->getArguments();
+        // Docs expert handoff
+        $docsHandoff = $csHandoffs[1];
+        $this->assertInstanceOf(Definition::class, $docsHandoff);
+        $docsHandoffArgs = $docsHandoff->getArguments();
         $this->assertSame('ai.agent.docs_expert', (string) $docsHandoffArgs[0]);
         $this->assertSame(['documentation', 'docs', 'readme', 'api', 'guide', 'tutorial'], $docsHandoffArgs[1]);