-
-
Notifications
You must be signed in to change notification settings - Fork 38
Open
Labels
AI BundleIssues & PRs about the AI integration bundleIssues & PRs about the AI integration bundleHelp wantedExtra attention is neededExtra attention is neededMCP BundleIssues & PRs about the MCP SDK integration bundleIssues & PRs about the MCP SDK integration bundle
Description
Currently, the bundles do not follow the rules applied in Symfony core (McpBundle does a mix):
- their services are all register using the FQCN as id. This makes any of those concrete implementation available for autowiring (which also means that adding traceable decorators implementing an interface to integrate in the profiler would become a BC break btw).
- they use autowiring and autoconfiguration, which means that the actual service definitions of the bundle can be impacted by autoconfiguration rules defined in projects, which will be a nightmare for people providing support in support channels (which includes myself)
Services should be registered under dedicated IDs (starting with ai.
or mcp.
to follow the best practices for shared bundles of using the bundle-specific prefix) and only supported autowirable types should have aliases registered using FQCN.
Services should also be wired explicitly to make maintenance and support easier by being sure that the actual service definition is the one we maintain.
chr-hertel and valtzu
Metadata
Metadata
Assignees
Labels
AI BundleIssues & PRs about the AI integration bundleIssues & PRs about the AI integration bundleHelp wantedExtra attention is neededExtra attention is neededMCP BundleIssues & PRs about the MCP SDK integration bundleIssues & PRs about the MCP SDK integration bundle