bug #1044 Always include locked dev packages (wouterj)

This PR was merged into the 2.x branch.

Discussion
----------

Always include locked dev packages

It took me ages to find this hidden bug.

When fetching the locked repository, Composer by default does not include dev packages. This means that conflicts for dev packages defined by Flex recipes were always completely ignored (like the `phpunit/phpunit: <9.6` conflict in our `symfony/phpunit-bridge` recipe).

This creates big issues for my new PHPUnit recipe (symfony/recipes#1401), as the 10+ recipe is run for applications using PHPUnit 9.

Commits
-------

05bcffd Always include locked dev packages

Author: fabpot

src/Downloader.php

@@ -134,7 +134,7 @@ public function getRecipes(array $operations): array
         $this->initialize();
 
         if ($this->conflicts) {
-            $lockedRepository = $this->composer->getLocker()->getLockedRepository();
+            $lockedRepository = $this->composer->getLocker()->getLockedRepository(true);
             foreach ($this->conflicts as $conflicts) {
                 foreach ($conflicts as $package => $versions) {
                     foreach ($versions as $version => $conflicts) {

src/Flex.php

@@ -872,7 +872,7 @@ private function doesRecipeConflict(array $recipeData, OperationInterface $opera
             return false;
         }
 
-        $lockedRepository = $this->composer->getLocker()->getLockedRepository();
+        $lockedRepository = $this->composer->getLocker()->getLockedRepository(true);
 
         foreach ($recipeData['manifest']['conflict'] as $conflictingPackage => $constraint) {
             if ($lockedRepository->findPackage($conflictingPackage, $constraint)) {