Skip to content

Commit 79367fc

Browse files
committed
Merge branch '6.4' into 7.0
* 6.4: DX: PHP CS Fixer - update excluded paths and apply some minor CS [AssetMapper] Optimize memory usage (load only "compilable" assets) [AssetMapper] Split ImportmapManager into 2 Rename fixtures paths to be consistent Add WorflowGuardListenerPass only if it exists [AssetMapper] Using ?specifier=* does not match unstable packages on jsdelivr [Worflow] Add a TraceableWorkflow
2 parents 84b4769 + 276a74d commit 79367fc

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

FrameworkBundle.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
use Symfony\Component\Validator\DependencyInjection\AddValidatorInitializersPass;
7070
use Symfony\Component\VarExporter\Internal\Hydrator;
7171
use Symfony\Component\VarExporter\Internal\Registry;
72+
use Symfony\Component\Workflow\DependencyInjection\WorkflowDebugPass;
7273
use Symfony\Component\Workflow\DependencyInjection\WorkflowGuardListenerPass;
7374

7475
// Help opcache.preload discover always-needed symbols
@@ -155,7 +156,7 @@ public function build(ContainerBuilder $container): void
155156
$container->addCompilerPass(new CachePoolClearerPass(), PassConfig::TYPE_AFTER_REMOVING);
156157
$container->addCompilerPass(new CachePoolPrunerPass(), PassConfig::TYPE_AFTER_REMOVING);
157158
$this->addCompilerPassIfExists($container, FormPass::class);
158-
$container->addCompilerPass(new WorkflowGuardListenerPass());
159+
$this->addCompilerPassIfExists($container, WorkflowGuardListenerPass::class);
159160
$container->addCompilerPass(new ResettableServicePass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, -32);
160161
$container->addCompilerPass(new RegisterLocaleAwareServicesPass());
161162
$container->addCompilerPass(new TestServiceContainerWeakRefPass(), PassConfig::TYPE_BEFORE_REMOVING, -32);
@@ -176,6 +177,7 @@ public function build(ContainerBuilder $container): void
176177
$container->addCompilerPass(new UnusedTagsPass(), PassConfig::TYPE_AFTER_REMOVING);
177178
$container->addCompilerPass(new ContainerBuilderDebugDumpPass(), PassConfig::TYPE_BEFORE_REMOVING, -255);
178179
$container->addCompilerPass(new CacheCollectorPass(), PassConfig::TYPE_BEFORE_REMOVING);
180+
$this->addCompilerPassIfExists($container, WorkflowDebugPass::class);
179181
}
180182
}
181183

Resources/config/asset_mapper.php

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
use Symfony\Component\AssetMapper\Factory\MappedAssetFactory;
3232
use Symfony\Component\AssetMapper\ImportMap\ImportMapAuditor;
3333
use Symfony\Component\AssetMapper\ImportMap\ImportMapConfigReader;
34+
use Symfony\Component\AssetMapper\ImportMap\ImportMapGenerator;
3435
use Symfony\Component\AssetMapper\ImportMap\ImportMapManager;
3536
use Symfony\Component\AssetMapper\ImportMap\ImportMapRenderer;
3637
use Symfony\Component\AssetMapper\ImportMap\ImportMapUpdateChecker;
@@ -101,7 +102,7 @@
101102
->args([
102103
service('asset_mapper.public_assets_path_resolver'),
103104
service('asset_mapper'),
104-
service('asset_mapper.importmap.manager'),
105+
service('asset_mapper.importmap.generator'),
105106
service('filesystem'),
106107
param('kernel.project_dir'),
107108
abstract_arg('public directory name'),
@@ -137,7 +138,7 @@
137138

138139
->set('asset_mapper.compiler.javascript_import_path_compiler', JavaScriptImportPathCompiler::class)
139140
->args([
140-
service('asset_mapper.importmap.manager'),
141+
service('asset_mapper.importmap.config_reader'),
141142
abstract_arg('missing import mode'),
142143
service('logger'),
143144
])
@@ -153,13 +154,19 @@
153154
->set('asset_mapper.importmap.manager', ImportMapManager::class)
154155
->args([
155156
service('asset_mapper'),
156-
service('asset_mapper.public_assets_path_resolver'),
157157
service('asset_mapper.importmap.config_reader'),
158158
service('asset_mapper.importmap.remote_package_downloader'),
159159
service('asset_mapper.importmap.resolver'),
160160
])
161161
->alias(ImportMapManager::class, 'asset_mapper.importmap.manager')
162162

163+
->set('asset_mapper.importmap.generator', ImportMapGenerator::class)
164+
->args([
165+
service('asset_mapper'),
166+
service('asset_mapper.public_assets_path_resolver'),
167+
service('asset_mapper.importmap.config_reader'),
168+
])
169+
163170
->set('asset_mapper.importmap.remote_package_storage', RemotePackageStorage::class)
164171
->args([
165172
abstract_arg('vendor directory'),
@@ -183,7 +190,7 @@
183190

184191
->set('asset_mapper.importmap.renderer', ImportMapRenderer::class)
185192
->args([
186-
service('asset_mapper.importmap.manager'),
193+
service('asset_mapper.importmap.generator'),
187194
service('assets.packages')->nullOnInvalid(),
188195
param('kernel.charset'),
189196
abstract_arg('polyfill URL'),
@@ -205,7 +212,6 @@
205212
->set('asset_mapper.importmap.command.require', ImportMapRequireCommand::class)
206213
->args([
207214
service('asset_mapper.importmap.manager'),
208-
param('kernel.project_dir'),
209215
service('asset_mapper.importmap.version_checker'),
210216
])
211217
->tag('console.command')

0 commit comments

Comments
 (0)