Skip to content

Commit abbb379

Browse files
committed
Merge branch '4.4' into 5.1
* 4.4: Fix CS [HttpClient][MockHttpClient][DX] Throw when the response factory callable does not return a valid response [FrameworkBundle] Do not pass the base uri twice to scoped http clients
2 parents 58cbeec + 33bb058 commit abbb379

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1927,9 +1927,12 @@ private function registerHttpClientConfiguration(array $config, ContainerBuilder
19271927
unset($scopeConfig['scope']);
19281928

19291929
if (null === $scope) {
1930+
$baseUri = $scopeConfig['base_uri'];
1931+
unset($scopeConfig['base_uri']);
1932+
19301933
$container->register($name, ScopingHttpClient::class)
19311934
->setFactory([ScopingHttpClient::class, 'forBaseUri'])
1932-
->setArguments([new Reference($httpClientId), $scopeConfig['base_uri'], $scopeConfig])
1935+
->setArguments([new Reference($httpClientId), $baseUri, $scopeConfig])
19331936
->addTag('http_client.client')
19341937
;
19351938
} else {

0 commit comments

Comments
 (0)