Use ::class keyword when possible

Author: fabpot

Tests/DefinitionTest.php

@@ -36,7 +36,7 @@ public function testSetInitialPlaces()
 
     public function testSetInitialPlaceAndPlaceIsNotDefined()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\LogicException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\LogicException::class);
         $this->expectExceptionMessage('Place "d" cannot be the initial place as it does not exist.');
         new Definition([], [], 'd');
     }
@@ -54,7 +54,7 @@ public function testAddTransition()
 
     public function testAddTransitionAndFromPlaceIsNotDefined()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\LogicException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\LogicException::class);
         $this->expectExceptionMessage('Place "c" referenced in transition "name" does not exist.');
         $places = range('a', 'b');
 
@@ -63,7 +63,7 @@ public function testAddTransitionAndFromPlaceIsNotDefined()
 
     public function testAddTransitionAndToPlaceIsNotDefined()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\LogicException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\LogicException::class);
         $this->expectExceptionMessage('Place "c" referenced in transition "name" does not exist.');
         $places = range('a', 'b');
 

Tests/Metadata/InMemoryMetadataStoreTest.php

@@ -77,7 +77,7 @@ public function testGetMetadata()
 
     public function testGetMetadataWithUnknownType()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidArgumentException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidArgumentException::class);
         $this->expectExceptionMessage('Could not find a MetadataBag for the subject of type "boolean".');
         $this->store->getMetadata('title', true);
     }

Tests/RegistryTest.php

@@ -61,7 +61,7 @@ public function testGetWithSuccess()
 
     public function testGetWithMultipleMatch()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidArgumentException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidArgumentException::class);
         $this->expectExceptionMessage('Too many workflows (workflow2, workflow3) match this subject (Symfony\Component\Workflow\Tests\Subject2); set a different name on each and use the second (name) argument of this method.');
         $w1 = $this->registry->get(new Subject2());
         $this->assertInstanceOf(Workflow::class, $w1);
@@ -70,7 +70,7 @@ public function testGetWithMultipleMatch()
 
     public function testGetWithNoMatch()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidArgumentException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidArgumentException::class);
         $this->expectExceptionMessage('Unable to find a workflow for class "stdClass".');
         $w1 = $this->registry->get(new \stdClass());
         $this->assertInstanceOf(Workflow::class, $w1);

Tests/Validator/StateMachineValidatorTest.php

@@ -11,7 +11,7 @@ class StateMachineValidatorTest extends TestCase
 {
     public function testWithMultipleTransitionWithSameNameShareInput()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidDefinitionException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidDefinitionException::class);
         $this->expectExceptionMessage('A transition from a place/state must have an unique name.');
         $places = ['a', 'b', 'c'];
         $transitions[] = new Transition('t1', 'a', 'b');
@@ -35,7 +35,7 @@ public function testWithMultipleTransitionWithSameNameShareInput()
 
     public function testWithMultipleTos()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidDefinitionException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidDefinitionException::class);
         $this->expectExceptionMessage('A transition in StateMachine can only have one output.');
         $places = ['a', 'b', 'c'];
         $transitions[] = new Transition('t1', 'a', ['b', 'c']);
@@ -58,7 +58,7 @@ public function testWithMultipleTos()
 
     public function testWithMultipleFroms()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidDefinitionException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidDefinitionException::class);
         $this->expectExceptionMessage('A transition in StateMachine can only have one input.');
         $places = ['a', 'b', 'c'];
         $transitions[] = new Transition('t1', ['a', 'b'], 'c');
@@ -106,7 +106,7 @@ public function testValid()
 
     public function testWithTooManyInitialPlaces()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidDefinitionException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidDefinitionException::class);
         $this->expectExceptionMessage('The state machine "foo" can not store many places. But the definition has 2 initial places. Only one is supported.');
         $places = range('a', 'c');
         $transitions = [];

Tests/Validator/WorkflowValidatorTest.php

@@ -14,7 +14,7 @@ class WorkflowValidatorTest extends TestCase
 
     public function testSinglePlaceWorkflowValidatorAndComplexWorkflow()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidDefinitionException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidDefinitionException::class);
         $this->expectExceptionMessage('The marking store of workflow "foo" can not store many places.');
         $definition = $this->createComplexWorkflowDefinition();
 
@@ -33,7 +33,7 @@ public function testSinglePlaceWorkflowValidatorAndSimpleWorkflow()
 
     public function testWorkflowWithInvalidNames()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidDefinitionException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidDefinitionException::class);
         $this->expectExceptionMessage('All transitions for a place must have an unique name. Multiple transitions named "t1" where found for place "a" in workflow "foo".');
         $places = range('a', 'c');
 
@@ -49,7 +49,7 @@ public function testWorkflowWithInvalidNames()
 
     public function testWithTooManyInitialPlaces()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\InvalidDefinitionException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\InvalidDefinitionException::class);
         $this->expectExceptionMessage('The marking store of workflow "foo" can not store many places. But the definition has 2 initial places. Only one is supported.');
         $places = range('a', 'c');
         $transitions = [];

Tests/WorkflowTest.php

@@ -22,7 +22,7 @@ class WorkflowTest extends TestCase
 
     public function testGetMarkingWithInvalidStoreReturn()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\LogicException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\LogicException::class);
         $this->expectExceptionMessage('The value returned by the MarkingStore is not an instance of "Symfony\Component\Workflow\Marking" for workflow "unnamed".');
         $subject = new Subject();
         $workflow = new Workflow(new Definition([], []), $this->getMockBuilder(MarkingStoreInterface::class)->getMock());
@@ -32,7 +32,7 @@ public function testGetMarkingWithInvalidStoreReturn()
 
     public function testGetMarkingWithEmptyDefinition()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\LogicException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\LogicException::class);
         $this->expectExceptionMessage('The Marking is empty and there is no initial place for workflow "unnamed".');
         $subject = new Subject();
         $workflow = new Workflow(new Definition([], []), new MethodMarkingStore());
@@ -42,7 +42,7 @@ public function testGetMarkingWithEmptyDefinition()
 
     public function testGetMarkingWithImpossiblePlace()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\LogicException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\LogicException::class);
         $this->expectExceptionMessage('Place "nope" is not valid for workflow "unnamed".');
         $subject = new Subject();
         $subject->setMarking(['nope' => 1]);
@@ -169,7 +169,7 @@ public function testCanWithSameNameTransition()
 
     public function testBuildTransitionBlockerListReturnsUndefinedTransition()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\UndefinedTransitionException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\UndefinedTransitionException::class);
         $this->expectExceptionMessage('Transition "404 Not Found" is not defined for workflow "unnamed".');
         $definition = $this->createSimpleWorkflowDefinition();
         $subject = new Subject();
@@ -249,7 +249,7 @@ public function testBuildTransitionBlockerListReturnsReasonsProvidedInGuards()
 
     public function testApplyWithNotExisingTransition()
     {
-        $this->expectException('Symfony\Component\Workflow\Exception\UndefinedTransitionException');
+        $this->expectException(\Symfony\Component\Workflow\Exception\UndefinedTransitionException::class);
         $this->expectExceptionMessage('Transition "404 Not Found" is not defined for workflow "unnamed".');
         $definition = $this->createComplexWorkflowDefinition();
         $subject = new Subject();