Skip to content

Commit e1f02eb

Browse files
Fixes #238. Money type is usable in show action.
Also refactored the complete columns, to remove code duplication such that this same error is prevented the next time.
1 parent 1af41ba commit e1f02eb

File tree

9 files changed

+32
-47
lines changed

9 files changed

+32
-47
lines changed
Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,7 @@
1-
{% use '../CommonAdmin/ListTemplate/Column/boolean.php.twig' %}
2-
{% use '../CommonAdmin/ListTemplate/Column/date.php.twig' %}
3-
{% use '../CommonAdmin/ListTemplate/Column/datetime.php.twig' %}
4-
{% use '../CommonAdmin/ListTemplate/Column/money.php.twig' %}
5-
{% use '../CommonAdmin/ListTemplate/Column/decimal.php.twig' %}
6-
{% use '../CommonAdmin/ListTemplate/Column/collection.php.twig' %}
1+
{% use '../CommonAdmin/PrintableColumns/columns.php.twig' %}
72

83
{% block column_default %}
94
{{ echo_block('list_td_column_' ~ column.name) -}}
10-
{%- if column.customView != null and builder.variable('custom_blocks') != null -%}
11-
{{- echo_use(builder.variable('custom_blocks')) -}}
12-
{{- echo_set('field_value', builder.ModelClass ~ '.' ~ column.getter, false) -}}
13-
{{- echo_print_block('column_' ~ column.customView|lower) -}}
14-
{%- elseif column.dbType|lower == "boolean" -%}
15-
{{- block('column_boolean') -}}
16-
{%- elseif column.dbType|lower == "date" -%}
17-
{{- block('column_date') -}}
18-
{%- elseif (column.dbType|lower == "datetime") or (column.dbType|lower == "timestamp") or (column.dbType|lower == "vardatetime") or (column.dbType|lower == "datetimetz") -%}
19-
{{- block('column_datetime') -}}
20-
{%- elseif column.formType|lower == "money" -%}
21-
{{- block('column_money') -}}
22-
{%- elseif column.dbType|lower == "decimal" -%}
23-
{{- block('column_decimal') -}}
24-
{%- elseif (column.dbType|lower == "array") or (column.dbType|lower == "collection") -%}
25-
{{- block('column_collection') -}}
26-
{%- else -%}
27-
{{- echo_twig(builder.ModelClass ~ '.' ~ column.getter) -}}
28-
{%- endif -%}
5+
{{- block('printable_columns') -}}
296
{{- echo_endblock() }}
307
{% endblock %}
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{% use '../CommonAdmin/PrintableColumns/boolean.php.twig' %}
2+
{% use '../CommonAdmin/PrintableColumns/date.php.twig' %}
3+
{% use '../CommonAdmin/PrintableColumns/datetime.php.twig' %}
4+
{% use '../CommonAdmin/PrintableColumns/money.php.twig' %}
5+
{% use '../CommonAdmin/PrintableColumns/decimal.php.twig' %}
6+
{% use '../CommonAdmin/PrintableColumns/collection.php.twig' %}
7+
8+
{% block printable_columns %}
9+
{%- if column.customView != null and builder.variable('custom_blocks') != null -%}
10+
{{- echo_use(builder.variable('custom_blocks')) -}}
11+
{{- echo_set('field_value', builder.ModelClass ~ '.' ~ column.getter, false) -}}
12+
{{- echo_print_block('column_' ~ column.customView|lower) -}}
13+
{%- elseif column.dbType|lower == "boolean" -%}
14+
{{- block('column_boolean') -}}
15+
{%- elseif column.dbType|lower == "date" -%}
16+
{{- block('column_date') -}}
17+
{%- elseif (column.dbType|lower == "datetime") or (column.dbType|lower == "timestamp") or (column.dbType|lower == "vardatetime") or (column.dbType|lower == "datetimetz") -%}
18+
{{- block('column_datetime') -}}
19+
{%- elseif column.formType|lower == "money" -%}
20+
{{- block('column_money') -}}
21+
{%- elseif column.dbType|lower == "decimal" -%}
22+
{{- block('column_decimal') -}}
23+
{%- elseif (column.dbType|lower == "array") or (column.dbType|lower == "collection") -%}
24+
{{- block('column_collection') -}}
25+
{%- else -%}
26+
{{- echo_twig(builder.ModelClass ~ '.' ~ column.getter) -}}
27+
{%- endif -%}
28+
{% endblock %}
Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,7 @@
1-
{% use '../CommonAdmin/ListTemplate/Column/boolean.php.twig' %}
2-
{% use '../CommonAdmin/ListTemplate/Column/date.php.twig' %}
3-
{% use '../CommonAdmin/ListTemplate/Column/datetime.php.twig' %}
4-
{% use '../CommonAdmin/ListTemplate/Column/decimal.php.twig' %}
5-
{% use '../CommonAdmin/ListTemplate/Column/collection.php.twig' %}
1+
{% use '../CommonAdmin/PrintableColumns/columns.php.twig' %}
62

73
{% block show_column %}
84
{{ echo_block('show_column_' ~ column.name) -}}
9-
{%- if column.customView != null and builder.variable('custom_blocks') != null -%}
10-
{{- echo_use(builder.variable('custom_blocks')) -}}
11-
{{- echo_set('field_value', builder.ModelClass ~ '.' ~ column.getter, false) -}}
12-
{{- echo_print_block('column_' ~ column.customView|lower) -}}
13-
{%- elseif column.dbType|lower == "boolean" -%}
14-
{{- block('column_boolean') -}}
15-
{%- elseif column.dbType|lower == "date" -%}
16-
{{- block('column_date') -}}
17-
{%- elseif (column.dbType|lower == "datetime") or (column.dbType|lower == "timestamp") or (column.dbType|lower == "vardatetime") or (column.dbType|lower == "datetimetz") -%}
18-
{{- block('column_datetime') -}}
19-
{%- elseif column.dbType|lower == "decimal" -%}
20-
{{- block('column_decimal') -}}
21-
{%- elseif (column.dbType|lower == "array") or (column.dbType|lower == "collection") -%}
22-
{{- block('column_collection') -}}
23-
{%- else -%}
24-
{{- echo_twig(builder.ModelClass ~ '.' ~ column.getter) -}}
25-
{%- endif -%}
5+
{{- block('printable_columns') -}}
266
{{- echo_endblock() }}
277
{% endblock %}

0 commit comments

Comments
 (0)