Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymPy version is outdated #20

Closed
sylee957 opened this issue Jul 31, 2023 · 9 comments · Fixed by #22
Closed

SymPy version is outdated #20

sylee957 opened this issue Jul 31, 2023 · 9 comments · Fixed by #22
Assignees

Comments

@sylee957
Copy link
Member

It is still 1.11.1 in SymPy live.

Regarding some issues with the updates,
I wonder if we can maintain this repository with dependabot

@ivanistheone
Copy link
Collaborator

I checked and 1.11.1 is indeed the latest available via micro pip, see https://pyodide.org/en/stable/usage/packages-in-pyodide.html I believe once they package a new version, the live shell will start using it. I'll keep an eye on this issue to make sure this happens.

Otherwise we might need to upgrade the jupyterlite version (this is what I had to do once in the past so that it picked up the new version).

As for dependabot, I don't think it understands micropip versions... although it would be nice.

@ivanistheone ivanistheone self-assigned this Aug 6, 2023
@oscarbenjamin
Copy link

Currently SymPy 1.12 is listed there.

It would be good to update to SymPy 1.13 though and also it would be good to have python-flint installed since 0.6.0 is available and SymPy 1.13 can make use of it.

@oscarbenjamin
Copy link

@oscarbenjamin
Copy link

I opened a PR to update the pyodide version of SymPy to 1.13.1: pyodide/pyodide#5098

In the meantime what can be done to get SymPy Live to run 1.12?

@agriyakhetarpal
Copy link
Collaborator

Hi all, Pyodide 0.27 released yesterday has now updated SymPy to 1.13.3, and this issue can now be closed by updating the jupyterlite-pyodide-kernel version to 0.4.7 and rebuilding the GitHub Pages deployment with it. Since this is a trivial update, I'm happy to either do this myself or step back if @ivanistheone, as the assignee, would still like to take care of it.

Please see https://github.com/jupyterlite/pyodide-kernel#compatibility and https://pyodide.org/en/stable/usage/packages-in-pyodide.html for more.

Happy new year!

@ivanistheone
Copy link
Collaborator

Let me take a look.

Since this repo based on the jupyterlite/demo repo, I'm going to look at what other changes were made to that repo and apply them too so we are current.

Diff of jupyterlite/demo since Apr 2023
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 77fa9fe..497ee55 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -13,11 +13,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
-          python-version: '3.10'
+          python-version: '3.11'
       - name: Install the dependencies
         run: |
           python -m pip install -r requirements.txt
@@ -26,7 +26,7 @@ jobs:
           cp README.md content
           jupyter lite build --contents content --output-dir dist
       - name: Upload artifact
-        uses: actions/upload-pages-artifact@v1
+        uses: actions/upload-pages-artifact@v3
         with:
           path: ./dist
 
@@ -45,4 +45,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v1
+        uses: actions/deploy-pages@v4


[0mdiff --git a/requirements.txt b/requirements.txt
index eda4081..60e3d0b 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,37 +1,36 @@
 # Core modules (mandatory)
-jupyterlite-core==0.1.0
-jupyterlab~=3.5.1
+jupyterlite-core==0.4.5
+jupyterlab~=4.2.5
+notebook~=7.2.2
+
 
 # Python kernel (optional)
-jupyterlite-pyodide-kernel==0.0.6
+jupyterlite-pyodide-kernel==0.4.5
 
 # JavaScript kernel (optional)
-jupyterlite-javascript-kernel==0.1.0b21
+jupyterlite-javascript-kernel==0.3.0
 
 # Language support (optional)
 jupyterlab-language-pack-fr-FR
 jupyterlab-language-pack-zh-CN
 
-# SQLite kernel (optional)
-jupyterlite-xeus-sqlite==0.2.1
 # P5 kernel (optional)
 jupyterlite-p5-kernel==0.1.0
-# Lua kernel (optional)
-jupyterlite-xeus-lua==0.3.1
 
 # JupyterLab: Fasta file renderer (optional)
-jupyterlab-fasta>=3,<4
+jupyterlab-fasta>=3.3.0,<4
 # JupyterLab: Geojson file renderer (optional)
-jupyterlab-geojson>=3,<4
+jupyterlab-geojson>=3.4.0,<4
 # JupyterLab: guided tour (optional)
-jupyterlab-tour
+# TODO: re-enable after https://github.com/jupyterlab-contrib/jupyterlab-tour/issues/82
+# jupyterlab-tour
 # JupyterLab: dark theme
 jupyterlab-night
 # JupyterLab: Miami nights theme (optional)
 jupyterlab_miami_nights
 
 # Python: ipywidget library for Jupyter notebooks (optional)
-ipywidgets>=8.0.0,<9
+ipywidgets>=8.1.3,<9
 # Python: ipyevents library for Jupyter notebooks (optional)
 ipyevents>=2.0.1
 # Python: interative Matplotlib library for Jupyter notebooks (optional)

@ivanistheone
Copy link
Collaborator

Yey, we live!

Image

Thanks to all who contributed to make this happen, in particular @oscarbenjamin @agriyakhetarpal who got the latest SymPy version into Pyodide.

@oscarbenjamin
Copy link

Thanks @ivanistheone and @agriyakhetarpal !

Oh, that is one thing we should do: the version should be displayed automatically somehow. When you run isympy in the terminal it looks like this:

$ isympy
IPython console for SymPy 1.14.dev (Python 3.13.1-64-bit) (ground types: flint)

These commands were executed:
>>> from sympy import *
>>> x, y, z, t = symbols('x y z t')
>>> k, m, n = symbols('k m n', integer=True)
>>> f, g, h = symbols('f g h', cls=Function)
>>> init_printing()

Documentation can be found at https://docs.sympy.org/dev


In [1]:

@agriyakhetarpal
Copy link
Collaborator

Sounds like a good idea. If I remember correctly, we were discussing this prospect somewhere, but I cannot recall where. I just opened #23 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants