-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry setting code #4
Comments
Regarding what is currently done in |
This code does exacly the same (using geometry from Rigid Block if present), but it does additional validity checks and gives a warning in case the geometry read from the device (or set / calculated) differs from the one in Rigid Block.
So it is done as follows - the geometry is read from "native" devices, for others (file images) it is either predefined (for std. floppies) or calculated (to be reasonable). However - if the device being opened has Rigid Disk block, the geometry is compared, reported if different (a warning is generated), and the one from Rigid disk block is being used. This is consistent with the earlier code. If the geometry in RDB is incorrect, it is up to the client code (application) to change/update it. |
The main issue is that geometry setting in done in several places and stages:
and it is done in
adfDevMountHd()
I would like to move all dealings with device geometry to opening a device - it should be set on any opened device (which can be that partitioned, formatted etc.).
While "mounting" a device is basically reading partition/volume information (if we move reading rigid block info).
The text was updated successfully, but these errors were encountered: