Skip to content

Commit 4c33d32

Browse files
committed
Update ChangeLog, remove "TODO" mark from tests related to RexOps#1508
This is made in a separate commit so to ease cherry-picking between two alternative fixes proposed in distinct commits. In any case, all tests pass either way. CHANGES: ============= modified: t/issue/1508.t modified: ChangeLog HOW TO TEST : ============= $ prove -v t/issue/1508.t # for this issue $ prove t/**/*.t # for non-regression
1 parent a011f27 commit 4c33d32

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

ChangeLog

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Revision history for Rex
55

66
[BUG FIXES]
77
- Detect invalid hostgroup expressions
8+
- Propagate args/params down to "needed" tasks launched by needs()
89

910
[DOCUMENTATION]
1011

t/issue/1508.t

+2-2
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,9 @@ task test6 => sub {
144144
T::check_needed( $_, { argv => \@_ } ) for (qw/test /);
145145
};
146146

147-
TODO: {
148-
local $TODO = "Issue 1508: The needs() function should propogate parameters/args";
149147

148+
149+
{
150150
my $task_list = Rex::TaskList->create;
151151
my $run_list = Rex::RunList->instance;
152152
$run_list->parse_opts(qw/test test2 test3 test5 test6/);

0 commit comments

Comments
 (0)