Skip to content

Commit 93a5135

Browse files
committed
Fix RexOps#1508 simply by correcting typo on a couple lines
Notice that how params and args were mixed up (interchanged) when being passed down -- within the needs() function. This appears to be a typo, introduced initially by PR RexOps#1157 (the fix for RexOps#1066 ) with 48c737b. CHANGES: ============= modified: lib/Rex/Command.pm HOW TO TEST : ============= $ prove -v t/issue/1508.t # for this issue $ prove t/**/*.t # for non-regression While the related tests remain marked as "TODO", they will not report failures during normal test runs. To see their true pass/fail status, you have to pass the '-v' option to `prove`.
1 parent 97f9e9a commit 93a5135

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/Rex/Commands.pm

+2-2
Original file line numberDiff line numberDiff line change
@@ -1066,11 +1066,11 @@ sub needs {
10661066
my $suffix = $self . ":";
10671067
if ( @args && grep ( /^\Q$task_name\E$/, @args ) ) {
10681068
Rex::Logger::debug( "Calling " . $task_o->name );
1069-
$task_o->run( "<func>", params => \@task_args, args => \%task_opts );
1069+
$task_o->run( "<func>", params => \%task_opts, args => \@task_args );
10701070
}
10711071
elsif ( !@args ) {
10721072
Rex::Logger::debug( "Calling " . $task_o->name );
1073-
$task_o->run( "<func>", params => \@task_args, args => \%task_opts );
1073+
$task_o->run( "<func>", params => \%task_opts, args => \@task_args );
10741074
}
10751075
}
10761076

0 commit comments

Comments
 (0)