Skip to content

Commit 17bfc94

Browse files
committed
Updates
Signed-off-by: Tyler Smalley <[email protected]>
1 parent c1fe4a5 commit 17bfc94

File tree

4 files changed

+21
-13
lines changed

4 files changed

+21
-13
lines changed

src/serve-panel-provider.ts

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,20 @@ export class ServePanelProvider implements vscode.WebviewViewProvider {
3636
case 'relayRequest': {
3737
const { id, endpoint, method } = m;
3838
Logger.info(`${id}, ${endpoint}, ${method}`, 'serve-panel');
39-
response = await this.ts.performFetch(endpoint, method, m.data);
40-
Logger.info(`response: ${JSON.stringify(response)}`, 'serve-panel');
41-
this.postMessage({
42-
id,
43-
endpoint,
44-
method,
45-
type: 'relayResponse',
46-
data: response,
47-
});
39+
try {
40+
response = await this.ts.performFetch(endpoint, method, m.data);
41+
Logger.info(`response: ${JSON.stringify(response)}`, 'serve-panel');
42+
this.postMessage({
43+
id,
44+
endpoint,
45+
method,
46+
type: 'relayResponse',
47+
data: response,
48+
});
49+
} catch (e) {
50+
vscode.window.showErrorMessage(`${e}`);
51+
}
52+
4853
break;
4954
}
5055

src/tailscale/cli.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ export class Tailscale {
251251
});
252252

253253
if (!resp.ok) {
254+
Logger.error(`${endpoint} failed: ${JSON.stringify(resp)}`);
254255
throw new Error(`${endpoint} failed`);
255256
}
256257

@@ -259,7 +260,9 @@ export class Tailscale {
259260
try {
260261
return JSON.parse(text);
261262
// eslint-disable-next-line no-empty
262-
} catch {}
263+
} catch {
264+
Logger.error(`failed to parse json: ${text}`);
265+
}
263266

264267
return text;
265268
} catch (e) {

src/webviews/serve-panel/simple-view.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { KB_FUNNEL_USE_CASES } from '../../utils/url';
88
import { useServe, useServeMutation } from './swr';
99
import { Tooltip } from './components/tooltip';
1010
import { errorForType } from '../../tailscale/error';
11-
import { serveReset, serveStatus } from '../tsrelay';
11+
import { serveReset, serveStatus, serveUpdate } from '../tsrelay';
1212
import { ServeParams, WithErrors } from '../../types';
1313

1414
export const SimpleView = () => {
@@ -228,7 +228,7 @@ export const SimpleView = () => {
228228
funnel: true,
229229
};
230230

231-
const resp = await serveReset();
231+
const resp = await serveUpdate(params);
232232
if (resp.Errors?.length && resp.Errors[0].Type === 'REQUIRES_SUDO') {
233233
vsCodeAPI.postMessage({
234234
type: 'sudoPrompt',

src/webviews/tsrelay.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,5 @@ export async function serveUpdate(arg?: ServeParams) {
2929
data: arg,
3030
})) as RelayServeResponse;
3131

32-
return reponse.data as unknown;
32+
return reponse.data as WithErrors;
3333
}

0 commit comments

Comments
 (0)