Skip to content

[Vue] A dialog opening right as another one is closing potentially breaks rendering #3746

Open
@fabis94

Description

@fabis94

What package within Headless UI are you using?

@headlessui/vue 1.7.23

What version of that package are you using?

@headlessui/vue 1.7.23

What browser are you using?

Edge

Reproduction URL

Hard to repro as the race condition has very tight timings, but i've got a reasonable fix ready already: #3745

Describe your issue

Even w/ the latest version of HeaadlessUI for Vue I was running into an issue where if a new dialog starts opening up while a previous dialog is in the process of closing down you can run into an issue where the old dialog starts removing the shared PortalRoot while the new dialog has already chosen to rely on it as its PortalRoot. This then ends up breaking the rendering of the 2nd dialog as it ends up being unmounted from the DOM along with the PortalRoot.

The fix is easy - just skip removing the portal root. I don't see any real benefits for removing it, I mean its just one single empty div node, there's no performance gain to having it be removed, and keeping it around fixes the race condition issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions