last week of year bug (week zoom view)

[naterg]

If you attempt to display an item with a to date of 12/31/13 the bar width will not render properly in the week zoom scale. It appears to be an oversight in the getDayForWeek function concerning weeks that span years?

-Nate

[chuliang]

Solution:
mbielanczuk#32 (comment)

[usmonster]

Anyone want to put that solution into a pull request? @julbuel ?

[taitems]

Guys I'm really keen to add collaborators to this project because the code base has gotten so out of control. Anything to get this stable (currently the hour view in particular is the most buggered) and close some of those pull requests.

[usmonster]

@taitems If you need help, I can sweep through some low-hanging-fruit issues and probably close a bunch. Would you also want to organize them in a certain way? Might be useful to have a couple categories/labels like "bug", "feature request", etc.. Lemme know.

[usmonster]

@naterg, according to the comment for that function (which seems rather convoluted in the first place), it looks like we want the equivalent of Moment.js's startOf('week').

If this is the case, we can pretty much replace the current function with something much simpler, something along the lines of return new Date(this.valueOf() - (8.64e7 * this.getDay()) ); // 1 day === 8.64e7 ms.

Untested and not sure if it's any more correct (would still have to account for DST), but it's a whole lot simpler in terms of approach. Thoughts? Anyone with more time want to test it out and maybe put it in a pull request? Otherwise I might do it, someday..

[naterg]

@usmonster, I've actually pulled off the project that was using jQuery.Gantt so I haven't even tested chuliang's solution. Appreciate the responses though and I'll notify if I jump back to using this!

[croftman]

I'v another bug with the weeks, if I have an event from 2014-12-29 to 2015-01-02, it put 2 weeks, from week 52 of 2014 to week 1 of 2015, but the first week of 2015 is 2014-12-29 to 2015-01-02 !

It's because my first day of week is monday ?

Ok I think it's the same issuer than #61

[usmonster]

@croftman I agree that your issue is the same as #61. Both issues are towards the top of the priority queue.