Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epubcheck-ruby silently exits if java is not on PATH #18

Closed
slonopotamus opened this issue Jul 28, 2021 · 2 comments
Closed

epubcheck-ruby silently exits if java is not on PATH #18

slonopotamus opened this issue Jul 28, 2021 · 2 comments

Comments

@slonopotamus
Copy link
Contributor

Downstream issue: asciidoctor/asciidoctor-epub3#404

It would be much more friendly if there was some kind of error message on stderr.
@slonopotamus slonopotamus mentioned this issue Jul 28, 2021
Open
@slonopotamus
Copy link
Contributor Author

slonopotamus commented Jul 28, 2021 •
edited
Loading

Proposed solutions:

  1. Simplest one: use exec instead of system in Epubcheck::Ruby::CLI#execute. Although this has a small chance of breaking someone's workflow it they are calling this method directly from Ruby code.
  2. Check system return value. If it is nil, print error message. But I'm not sure we can get error description from anywhere: is java missing? Or maybe it doesn't have executable bit set?
  3. Suggest your own

@takahashim
Copy link
Owner

Thank you for your feedback! I use 2, which is a simple solution.

takahashim added a commit that referenced this issue Aug 1, 2021
@takahashim
Merge pull request #19 from takahashim/18-fix-system-failed
449db3b 
Fix to explicitly exit when system failed; fixed #18
meonkeys added a commit to meonkeys/shb that referenced this issue Jan 12, 2024
@meonkeys
fix epubcheck
e6e7731 
and remove bsdextrautils. Not sure what that was for, everything still builds just fine without it.

See also:

* <takahashim/epubcheck-ruby#18>
* <asciidoctor/asciidoctor-epub3#404>
meonkeys added a commit to meonkeys/shb that referenced this issue Jan 12, 2024
@meonkeys
fix epubcheck
5270a73 
and remove bsdextrautils. Not sure what that was for, everything still builds just fine without it.

See also:

* <takahashim/epubcheck-ruby#18>
* <asciidoctor/asciidoctor-epub3#404>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takahashim @slonopotamus