compiled with clang++, fixed compile warnings with both g++ and clang++

Author: cosmos72

Makefile.in

@@ -84,6 +84,7 @@ DIST_COMMON = INSTALL NEWS README AUTHORS ChangeLog \
 	$(top_srcdir)/tools/install-sh $(top_srcdir)/tools/missing
 ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
 am__aclocal_m4_deps = $(top_srcdir)/acinclude.m4 \
+	$(top_srcdir)/tools/ft_cxx_flags.m4 \
 	$(top_srcdir)/tools/ft_cxx_features.m4 \
 	$(top_srcdir)/tools/ft_cxx_unordered_map.m4 \
 	$(top_srcdir)/tools/ft_need_funcs.m4 \

README.md

@@ -1,25 +1,25 @@
-###############################################################################
-###############################################################################
-###############################################################################
-#########                                                             #########
-#########             THIS DOCUMENT EXPLAINS HOW TO USE               #########
-#########               RISKY PROGRAMS AND PROCEDURES                 #########
-#########        THAT MAY COMPLETELY AND IRREVERSIBLY DELETE          #########
-#########                ALL THE DATA ON YOUR DISKS                   #########
-#########                                                             #########
-#########         THE AUTHOR DECLINES ALL RESPONSIBILITIES            #########
-#########               FOR ANY DAMAGE THAT MAY DERIVE                #########
-#########           FROM USING THE PROGRAMS AND PROCEDURES            #########
-#########               DESCRIBED IN THIS DOCUMENT                    #########
-#########                                                             #########
-###############################################################################
-###############################################################################
-###############################################################################
-
-This document explains how use the programs 'fstransform', 'fsmove'
-and 'fsremap' to transform the contents of a Linux device
-- usually a disk partition - from a filesystem type to another
-while preserving its contents.
+###############################################################
+###############################################################
+###
+###                        DISCLAIMER
+###
+###             THIS DOCUMENT EXPLAINS HOW TO USE
+###               RISKY PROGRAMS AND PROCEDURES
+###        THAT MAY COMPLETELY AND IRREVERSIBLY DELETE
+###                ALL THE DATA ON YOUR DISKS
+###
+###         THE AUTHOR DECLINES ALL RESPONSIBILITIES
+###               FOR ANY DAMAGE THAT MAY DERIVE
+###           FROM USING THE PROGRAMS AND PROCEDURES
+###               DESCRIBED IN THIS DOCUMENT
+###
+###############################################################
+###############################################################
+
+
+This document explains how use the programs 'fstransform', 'fsmove' and
+'fsremap' to transform the contents of a Linux device - usually a disk
+partition - from a filesystem type to another while preserving its contents.
 
 For example, a disk partition can be transformed from 'jfs' to 'ext4',
 or from 'ext2' to 'xfs', or many other combinations. 
@@ -48,9 +48,10 @@ All this foreword means only one thing:
 The author declines ALL responsibilities for ANY damage that may derive
 from using the programs and procedures described in this document.
 
-###############################################################################
-###############################################################################
-###############################################################################
+###############################################################
+###############################################################
+
+### Introduction
 
 Enough legalese... now let's get to the interesting part.
 
@@ -66,9 +67,11 @@ It works even if the filesystem is almost full
 and even if it contains very large files, for example if some files
 are larger than half the device or larger than the available space.
 
+### REQUIREMENTS
+
 There are four requirements for fstransform to have a chance to succeed:
 
-1) the device must have a little free space, typically at least 5%
+1. the device must have a little free space, typically at least 5%
 
    WARNING: transforming an almost full device to 'xfs' file-system
    can be tricky:
@@ -79,7 +82,7 @@ There are four requirements for fstransform to have a chance to succeed:
      before resuming fstransform.
      A future fstransform version may automate this operation.
 
-2) the filesystem on the device must support SPARSE FILES, i.e. files with holes
+2. the filesystem on the device must support SPARSE FILES, i.e. files with holes
    (see for example http://en.wikipedia.org/wiki/Sparse_file for an explanation of what they are)
    and at least one of the two system calls "ioctl(FS_IOC_FIEMAP)" or "ioctl(FIBMAP)"
    (see the file Documentation/filesystems/fiemap.txt in any recent Linux kernel
@@ -88,24 +91,25 @@ There are four requirements for fstransform to have a chance to succeed:
    ioctl(FIBMAP) is limited by design to 2G-1 blocks, which typically translates to 8TB - 4kB.
    To transform file systems equal or larger than 8TB, ioctl(FIEMAP) is required.
 
-3) the initial and final filesystems must be supported by the Linux kernel
+3. the initial and final filesystems must be supported by the Linux kernel
    (i.e. it must be able to mount them)
    and by the tools 'mkfs' and 'fsck'
    (i.e. it must be possible to create them and check them for errors)
 
-4) the following programs must be available:
+4. the following programs must be available:
    the two custom-made programs 'fsmove' and 'fsremap' (distributed with the script)
    and several common Linux tools:
       which, expr, id, blockdev, losetup, mount, umount,
       mkdir, rmdir, rm, mkfifo, dd, sync, fsck, mkfs 
 
 
-KNOWN LIMITS:
+### KNOWN LIMITS
+
+* If the device contains a HUGE number of files with multiple hard links,
+  fstransform will be very slow and consume a LOT of memory.
+  Devices with more than one million files with multiple hard links
+  can cause fstransform to crash with "out of memory" errors.
 
-1) if the device contains a HUGE number of files with multiple hard links,
-   fstransform will be very slow and consume a LOT of memory.
-   Devices with more than one million files with multiple hard links
-   can cause fstransform to crash with "out of memory" errors.
 
 2) JFS file systems equal or larger than 8TB cannot be converted due to
    missing support for ioctl(FIEMAP) in the kernel:
@@ -120,7 +124,8 @@ KNOWN LIMITS:
 4) for the same reason, a device cannot be converted _to_ REISERFS format "3.5"
    if it contains files larger than 2TB - 4k.
 
-FOREWORD:
+
+### DETAILS TO KNOW
 
 If the original device is almost full, the program 'fsremap'
 will create a relatively small backup file ("secondary storage")
@@ -136,9 +141,9 @@ To pass the same option to 'fstransform', you must execute something like
   fstransform --opts-fsremap='-s <size>' <other-options-and-arguments> 
 
 
-PROCEDURE:
+### PROCEDURE
 
-0) compile fsmove and fsremap.
+0. compile fsmove and fsremap.
    Running "./configure" then "make" should suffice on any recent Linux machine,
    as long as g++ is installed.
 
@@ -152,15 +157,15 @@ PROCEDURE:
    Below, they will be referred as {fsmove} and {fsremap}
 
 
-1) OPTIONAL - CAN BE SKIPPED
+1. OPTIONAL - CAN BE SKIPPED
    mount read-write the device you want to remap to a new file-system type
 
    mount {device} {device-mount-point} [your-options]
 
    if the device is already mounted, check that it is mounted read-write
    and that no process is using it.
 
-2) decide the target file-system type.
+2. decide the target file-system type.
 
    For some combinations of the initial and final filesystems
    it is not necessary to use 'fstransform',
@@ -175,14 +180,14 @@ PROCEDURE:
    "convert Linux File System ext2 to ext3" 
    "convert Linux File System ext3 to ext4" 
 
-   But for most combinations, the only way is either to do a full backup + format +
-   restore the data, or use 'fstransform'
+   But for most combinations, the only way is either to do a full backup +
+   format + restore the data, or use 'fstransform'
 
-3) execute the program
+3. execute the program
 
    fstransform {device} {target-file-system-type}
 
-4) follow the instructions - the program will tell you what it is doing,
+4. follow the instructions - the program will tell you what it is doing,
    and will also call 'fsmove' and 'fsremap' which show progress percentage
    and estimated time left.
 
@@ -193,10 +198,11 @@ PROCEDURE:
    In case there are errors, you can even try to fix them instead of
    aborting the execution (if you know what you are doing).
 
-5) be PATIENT. Transforming a large device takes a LONG time...
-   On a fairly fast disk, it takes about 1 minute per 1 gigabyte.
-   It means transforming 250GB of takes about 4 hours.
-   Solid state disks (SSD) can be much faster.
+5. be PATIENT. Transforming a large device takes a LONG time...
+   On a fairly fast disk, it takes about one minute per gigabyte.
+   It means transforming 1000GB takes about 16 hours.
+   Raid disks can be somewhat faster, and solid state disks (SSD)
+   can be _much_ faster.
 
 6) if something goes really wrong, check in /var/tmp/fstransform
    for the log files

acinclude.m4

@@ -1,3 +1,4 @@
+m4_include([tools/ft_cxx_flags.m4])
 m4_include([tools/ft_cxx_features.m4])
 m4_include([tools/ft_cxx_unordered_map.m4])
 m4_include([tools/ft_need_funcs.m4])

configure

@@ -3637,8 +3637,111 @@ ac_compiler_gnu=$ac_cv_cxx_compiler_gnu
 # Checks for compiler characteristics
 
 
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $ac_cv_prog_ac_ct_CXX supports explicit template instantiation" >&5
-$as_echo_n "checking whether $ac_cv_prog_ac_ct_CXX supports explicit template instantiation... " >&6; }
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CXX accepts -Wall" >&5
+$as_echo_n "checking whether $CXX accepts -Wall... " >&6; }
+if ${ac_cv_cxx_flag_Wall+:} false; then :
+  $as_echo_n "(cached) " >&6
+else
+  save_CXXFLAGS="$CXXFLAGS"
+     CXXFLAGS="$CXXFLAGS -Wall"
+     cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h.  */
+
+
+int
+main ()
+{
+
+      return 0;
+
+  ;
+  return 0;
+}
+_ACEOF
+if ac_fn_cxx_try_compile "$LINENO"; then :
+  ac_cv_cxx_flag_Wall=yes
+else
+  ac_cv_cxx_flag_Wall=no
+     CXXFLAGS="$save_CXXFLAGS"
+
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+
+fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_cxx_flag_Wall" >&5
+$as_echo "$ac_cv_cxx_flag_Wall" >&6; }
+
+  { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CXX accepts -Wextra" >&5
+$as_echo_n "checking whether $CXX accepts -Wextra... " >&6; }
+if ${ac_cv_cxx_flag_Wextra+:} false; then :
+  $as_echo_n "(cached) " >&6
+else
+  save_CXXFLAGS="$CXXFLAGS"
+     CXXFLAGS="$CXXFLAGS -Wextra"
+     cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h.  */
+
+
+int
+main ()
+{
+
+      return 0;
+
+  ;
+  return 0;
+}
+_ACEOF
+if ac_fn_cxx_try_compile "$LINENO"; then :
+  ac_cv_cxx_flag_Wextra=yes
+else
+  ac_cv_cxx_flag_Wextra=no
+     CXXFLAGS="$save_CXXFLAGS"
+
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+
+fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_cxx_flag_Wextra" >&5
+$as_echo "$ac_cv_cxx_flag_Wextra" >&6; }
+
+  { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CXX accepts -W" >&5
+$as_echo_n "checking whether $CXX accepts -W... " >&6; }
+if ${ac_cv_cxx_flag_W+:} false; then :
+  $as_echo_n "(cached) " >&6
+else
+  save_CXXFLAGS="$CXXFLAGS"
+     CXXFLAGS="$CXXFLAGS -W"
+     cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h.  */
+
+
+int
+main ()
+{
+
+      return 0;
+
+  ;
+  return 0;
+}
+_ACEOF
+if ac_fn_cxx_try_compile "$LINENO"; then :
+  ac_cv_cxx_flag_W=yes
+else
+  ac_cv_cxx_flag_W=no
+     CXXFLAGS="$save_CXXFLAGS"
+
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+
+fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_cxx_flag_W" >&5
+$as_echo "$ac_cv_cxx_flag_W" >&6; }
+
+
+  { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CXX supports explicit template instantiation" >&5
+$as_echo_n "checking whether $CXX supports explicit template instantiation... " >&6; }
 if ${ac_cv_cxx_have_template_instantiation+:} false; then :
   $as_echo_n "(cached) " >&6
 else
@@ -3679,8 +3782,8 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_cxx_have_template_instantiation" >&5
 $as_echo "$ac_cv_cxx_have_template_instantiation" >&6; }
 
-  { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $ac_cv_prog_ac_ct_CXX supports inhibiting template instantiation" >&5
-$as_echo_n "checking whether $ac_cv_prog_ac_ct_CXX supports inhibiting template instantiation... " >&6; }
+  { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CXX supports inhibiting template instantiation" >&5
+$as_echo_n "checking whether $CXX supports inhibiting template instantiation... " >&6; }
 if ${ac_cv_cxx_have_template_inhibition+:} false; then :
   $as_echo_n "(cached) " >&6
 else

configure.ac

@@ -17,6 +17,7 @@ AC_PROG_INSTALL
 AC_LANG(C++)
 
 # Checks for compiler characteristics
+FT_CXX_FLAGS
 FT_CXX_FEATURES
 
 # Checks for header files.

fsattr/build/Makefile.in

@@ -82,6 +82,7 @@ DIST_COMMON = $(srcdir)/Makefile.in $(srcdir)/Makefile.am \
 	$(top_srcdir)/tools/depcomp
 ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
 am__aclocal_m4_deps = $(top_srcdir)/acinclude.m4 \
+	$(top_srcdir)/tools/ft_cxx_flags.m4 \
 	$(top_srcdir)/tools/ft_cxx_features.m4 \
 	$(top_srcdir)/tools/ft_cxx_unordered_map.m4 \
 	$(top_srcdir)/tools/ft_need_funcs.m4 \

fsmove/build/Makefile.in

@@ -82,6 +82,7 @@ DIST_COMMON = $(srcdir)/Makefile.in $(srcdir)/Makefile.am \
 	$(top_srcdir)/tools/depcomp
 ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
 am__aclocal_m4_deps = $(top_srcdir)/acinclude.m4 \
+	$(top_srcdir)/tools/ft_cxx_flags.m4 \
 	$(top_srcdir)/tools/ft_cxx_features.m4 \
 	$(top_srcdir)/tools/ft_cxx_unordered_map.m4 \
 	$(top_srcdir)/tools/ft_need_funcs.m4 \

fsmove/src/io/io_posix.cc

@@ -214,15 +214,15 @@ int fm_io_posix::disk_stat(const char * path, fm_disk_stat & disk_stat)
 /**
  * use some file-system specific trickery and try to free some space.
  */
-void fm_io_posix::try_to_make_free_space(const char * path)
+void fm_io_posix::try_to_make_free_space(const char * FT_ARG_UNUSED(path))
 {
 #if 0
     /* 
      * we COULD run 'xfs_fsr <path>' and try to free some space on 'xfs' file-systems,
      * but at least on linux with an almost-full source device
      * xfs_fsr can WORSEN the problem by triggering 'loop write error' kernel errors,
      * which mean the source device has not enough space to accommodate the loop file contents.
-     * typically this CORRUPTS the file system inside target (loop) device!
+     * this typically CORRUPTS the file system inside target (loop) device!
      */
     const char * cmd = "xfs_fsr";
     const char * const args[] = { cmd, path, NULL };

fsmove/src/io/io_prealloc.cc

@@ -83,7 +83,7 @@ void fm_io_prealloc::sync()
  * Since we are preallocating, we can (and will) avoid any modification
  * to the source file system. Thus this method does nothing.
  */
-int fm_io_prealloc::remove_file(const char * source_path)
+int fm_io_prealloc::remove_file(const char * FT_ARG_UNUSED(source_path))
 {
     return 0;
 }
@@ -93,7 +93,7 @@ int fm_io_prealloc::remove_file(const char * source_path)
  * Since we are preallocating, we can (and will) avoid any modification
  * to the source file system. Thus this method does nothing.
  */
-int fm_io_prealloc::remove_special(const char * source_path)
+int fm_io_prealloc::remove_special(const char * FT_ARG_UNUSED(source_path))
 {
     return 0;
 }
@@ -114,7 +114,7 @@ int fm_io_prealloc::remove_dir(const ft_string & path)
  * copy the contents of regular file 'source_path' to 'target_path'.
  * Since we are preallocating, we just preallocate enough blocks inside 'target_path'
  */
-int fm_io_prealloc::copy_file_contents(const ft_string & source_path, const ft_stat & source_stat, const ft_string & target_path)
+int fm_io_prealloc::copy_file_contents(const ft_string & FT_ARG_UNUSED(source_path), const ft_stat & source_stat, const ft_string & target_path)
 {
     const char * target = target_path.c_str();
     int err = 0;