[feature] change default image repository to ghcr (kubeflow#872)

* change default image repository to ghcr

Signed-off-by: mahdikhashan <[email protected]>

* remove docker credential access in csi workflow

Signed-off-by: mahdikhashan <[email protected]>

* remove docker credentials from workflow

Signed-off-by: mahdikhashan <[email protected]>

* remove docker credentials from ui workflow

Signed-off-by: mahdikhashan <[email protected]>

* set registry in build script and remove credential

Signed-off-by: mahdikhashan <[email protected]>

* revert docker credentials

Signed-off-by: mahdikhashan <[email protected]>

* use github action credentials in the workflow

Signed-off-by: mahdikhashan <[email protected]>

* use github action credentials

Signed-off-by: mahdikhashan <[email protected]>

* use github action credentials

Signed-off-by: mahdikhashan <[email protected]>

* pull images from ghcr

Signed-off-by: mahdikhashan <[email protected]>

* pull from ghcr

Signed-off-by: mahdikhashan <[email protected]>

* gha: align py test to registry param

Signed-off-by: Matteo Mortari <[email protected]>

* gha: align .github/workflows/build-image-pr.yml to img registry param

Signed-off-by: Matteo Mortari <[email protected]>

---------

Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Co-authored-by: Matteo Mortari <[email protected]>

Author: mahdikhashan

.github/workflows/build-and-push-csi-image.yml

@@ -16,9 +16,9 @@ on:
 env:
   IMG_ORG: kubeflow
   IMG_REPO: model-registry-storage-initializer
-  DOCKER_USER: ${{ secrets.DOCKERHUB_USERNAME }}
-  DOCKER_PWD: ${{ secrets.DOCKERHUB_TOKEN }}
   PUSH_IMAGE: true
+  DOCKER_USER: ${{ github.actor }}
+  DOCKER_PWD: ${{ secrets.GITHUB_TOKEN }}
 jobs:
   build-csi-image:
     runs-on: ubuntu-latest

.github/workflows/build-and-push-image.yml

@@ -16,9 +16,9 @@ on:
 env:
   IMG_ORG: kubeflow
   IMG_REPO: model-registry
-  DOCKER_USER: ${{ secrets.DOCKERHUB_USERNAME }}
-  DOCKER_PWD: ${{ secrets.DOCKERHUB_TOKEN }}
   PUSH_IMAGE: true
+  DOCKER_USER: ${{ github.actor }}
+  DOCKER_PWD: ${{ secrets.GITHUB_TOKEN }}
 jobs:
   build-image:
     runs-on: ubuntu-latest

.github/workflows/build-and-push-ui-images.yml

@@ -10,9 +10,9 @@ on:
 env:
   IMG_ORG: kubeflow
   IMG_UI_REPO: model-registry-ui
-  DOCKER_USER: ${{ secrets.DOCKERHUB_USERNAME }}
-  DOCKER_PWD: ${{ secrets.DOCKERHUB_TOKEN }}
   PUSH_IMAGE: true
+  DOCKER_USER: ${{ github.actor }}
+  DOCKER_PWD: ${{ secrets.GITHUB_TOKEN }}
 jobs:
   build-image:
     runs-on: ubuntu-latest

.github/workflows/build-image-pr.yml

@@ -12,6 +12,7 @@ on:
       - "docs/**"
       - "clients/python/**"
 env:
+  IMG_REGISTRY: ghcr.io
   IMG_ORG: kubeflow
   IMG_REPO: model-registry
   PUSH_IMAGE: false
@@ -44,12 +45,12 @@ jobs:
           sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
       - name: Load Local Registry Test Image
         env:
-          IMG: "${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
+          IMG: "${{ env.IMG_REGISTRY }}/${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
         run: |
           kind load docker-image -n chart-testing ${IMG}
       - name: Deploy Model Registry using manifests
         env:
-          IMG: "${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
+          IMG: "${{ env.IMG_REGISTRY }}/${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
         run: ./scripts/deploy_on_kind.sh
       - name: Deployment logs
         run: |

.github/workflows/python-tests.yml

@@ -134,6 +134,7 @@ jobs:
             kubernetes-version: "v1.27.11"
     env:
       FORCE_COLOR: "1"
+      IMG_REGISTRY: ghcr.io
       IMG_ORG: kubeflow
       IMG_REPO: model-registry
     steps:
@@ -199,12 +200,12 @@ jobs:
           sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
       - name: Load Local Registry Test Image
         env:
-          IMG: "${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
+          IMG: "${{ env.IMG_REGISTRY }}/${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
         run: |
           kind load docker-image -n chart-testing-py-${{ matrix.python }} ${IMG}
       - name: Deploy Model Registry using manifests
         env:
-          IMG: "${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
+          IMG: "${{ env.IMG_REGISTRY }}/${{ env.IMG_ORG }}/${{ env.IMG_REPO }}:${{ steps.tags.outputs.tag }}"
         run: ./scripts/deploy_on_kind.sh
       - name: Deploy Minio using manifests
         run: |

Makefile

@@ -19,8 +19,8 @@ MLMD_VERSION ?= 1.14.0
 DOCKER ?= docker
 # default Dockerfile
 DOCKERFILE ?= Dockerfile
-# container registry, default to empty (dockerhub) if not explicitly set
-IMG_REGISTRY ?= 
+# container registry, default to github container registry
+IMG_REGISTRY ?= ghcr.io
 # container image organization
 IMG_ORG ?= kubeflow
 # container image version

manifests/kustomize/base/model-registry-deployment.yaml

@@ -29,7 +29,7 @@ spec:
           command:
             - /model-registry
             - proxy
-          image: kubeflow/model-registry:latest
+          image: ghcr.io/kubeflow/model-registry:latest
           # empty placeholder environment for patching
           env: []
           ports:

manifests/kustomize/options/csi/clusterstoragecontainer.yaml

@@ -5,7 +5,7 @@ metadata:
 spec:
   container:
     name: storage-initializer
-    image: kubeflow/model-registry-storage-initializer:latest
+    image: ghcr.io/kubeflow/model-registry-storage-initializer:latest
     env:
     - name: MODEL_REGISTRY_BASE_URL
       value: "model-registry-service.kubeflow.svc.cluster.local:8080"

manifests/kustomize/options/ui/base/kustomization.yaml

@@ -9,5 +9,5 @@ resources:
 
 images:
 - name: model-registry-ui
-  newName: docker.io/kubeflow/model-registry-ui
+  newName: ghcr.io/kubeflow/model-registry-ui
   newTag: latest

scripts/build_deploy.sh

@@ -3,7 +3,7 @@
 set -e
 
 # see Makefile for the IMG_ variables semantic
-IMG_REGISTRY=""
+IMG_REGISTRY="${IMG_REGISTRY:-ghcr.io}"
 IMG_ORG="${IMG_ORG:-kubeflow}"
 IMG_REPO="${IMG_REPO:-model-registry}"
 DOCKER_USER="${DOCKER_USER}"